Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
832 stars 93 forks source link

Actions unavailable and icons dimmed for TV Shows #1687

Open bouvin opened 10 months ago

bouvin commented 10 months ago

Describe the bug

Something I have never seen before: I can scrape and save information about movies just fine, but the keyboard commands for Scraping/Save/Save All/Rename do not work for TV Shows. Likewise, the matching icons are dimmed when in TV Shows, and right-clicking on a show and, e.g., selecting Load Information does nothing.

When the bug has occurred I cannot access Settings through the icon nor Cmd-, anymore – in Movies and TV Shows alike, while I can still Reload all Movies/TV Shows

I have tried uninstalling and reinstalling (through brew), as well as removing all kvibes files and folders from ~/Library/

I have also made a fresh install on a different Mac (Mac mini M1 whereas the first was Intelbased)

The media folders in question do not appear to be write protected.

The extra puzzling part is that it worked just fine two days ago. Could there be some other (qt?) update through brew that slew the application?

To Reproduce In my case, adding a TV Show folder, searching for shows, and then clicking on a show will dim the icons as described above and render the ability to scrape or view information impossible.

Expected behavior Being able to still access these actions, as per usual.

MediaElch Version:

Operating System:

Additional context MediaElch 2.10.6 - Benzar

Compiled with Qt version 6.6.1 (64 Release, Clang 15.0 (Apple)) Using Qt version 6.6.1 System: macOS 14.1 (x86_64-little_endian-lp64)

Application directory: /Applications/MediaElch.app/Contents/MacOS Settings file: /Users/bouvin/Library/Preferences/com.kvibes.MediaElch.plist Data dir: /Users/bouvin/Library/Application Support/kvibes/MediaElch Image cache directory: /Users/bouvin/Library/Application Support/kvibes/MediaElch Qt Translation Path: /Applications/MediaElch.app/Contents/translations

MediaInfo Version: MediaInfoLib - v23.07

Default UI languages: en-DK, en-Latn-DK, da-DK, da-Latn-DK, da

Custom advancedsettings.xml: false

bugwelle commented 10 months ago

Hi,

on macOS, Qt is bundled in the .dmg files, which is distributed through Homebrew.

What I encountered before: The settings window was "hidden" (moved to another screen, etc), and the main actions were not accessible.

So: If you start MediaElch, then go to "TV Shows", are the icons still disabled?

I'm just wondering, because the "main window functionality" isn't something that I've touched during the last release.

Another test: If you use the dmg for Qt5 from https://mediaelch-downloads.ameyering.de/releases/v2.10.6/ , does it happen there as well? (the MediaElch binary is basically the same, only the Qt version differs; you don't need to install MediaElch, you can just run it by clicking on MediaElch in die DMG preview window).

Also: I only have a Mac with Intel chip. I don't know if it's related to that or not.

Regards, Andre

bouvin commented 10 months ago

Thank you.

I have been running and rerunning the MediaElch directly from MediaElch_macOS_11_or_later_Qt6_2.10.6_2023-12-03_git-6121419e.dmg. The results have unfortunately been inconclusive:

I am running this on an Intel Mac mini.

bugwelle commented 9 months ago

Thanks. I will try to look into this issue between holidays.

bugwelle commented 9 months ago

I can reproduce. But it's so strange. I didn't notice this in debug builds...

bugwelle commented 9 months ago

This only happens after scraping a single episode. The reason seems to be that for whatever reason, Qt signals don't reach their slots. I don't know why, yet.

bouvin commented 9 months ago

Thank you for working on this!

I am heartened that the behaviour is reproducible :)

bugwelle commented 9 months ago

Oh man. This could be a Qt bug. Everything works fine with Qt 5.15. But with Qt 6.6, it doesn't work. I will try an older Qt 6 version. I really hope this is a bug on my side, because debugging Qt bugs is something I'm not that good at. 😄

So: "workaround". use the Qt5 version of MediaElch. It may look "older" (because Qt6 has introduced HighDPI support), but it should work. Your issue is reproducible with Qt 6.6.1. It also appears that episode images are not loaded with the Qt6 version. The Qt5 version works just fine.

Regards, Andre

bugwelle commented 9 months ago

It works with Qt 6.4.3. Appears to be a Qt bug.

I've prepared a version with Qt 6.4.3 for you. No difference to the latest stable version besides the Qt version.

This is just so annoying. Two major bugs (one of them being a crash) due to bugs in Qt.

Thanks for reporting this issue!

bugwelle commented 9 months ago

This is the Qt bug https://bugreports.qt.io/browse/QTBUG-119513

The code flow just stops at a comboBox->insertItems() call in MediaElch. But for whatever reason, MediaElch does not crash.

bouvin commented 9 months ago

I can confirm that the prepared version works just as intended. Thank you!