search

Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
807 stars 93 forks source link

Renamer ignores 'Rename Directories' setting #1719

Open BCVerdouw opened 5 months ago

BCVerdouw commented 5 months ago

Describe the bug Renamer ignores whether or not the "Rename Directories" option is checked or not

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Shows'
  2. Click on 'Rename selected files'
  3. Fill a random value into the 'Directory Naming' field
  4. Disable 'Rename Directories'
  5. Click 'Dry Run'
  6. See that it still tries to rename the directory.

Expected behavior When 'Rename Directories' is disabled it should not try to rename the directories

Screenshots If applicable, add screenshots to help explain your problem. image image image

MediaElch Version:

Operating System:

Additional context This is definitely a regression, seeing as it worked as intended before.

bugwelle commented 4 months ago

Hi,

thanks for reporting this issue. Did you enable "Sep. Folders" for your TV shows in MediaElch's settings?

Regards, Andre

BCVerdouw commented 4 months ago

Good morning, my apologies for the late reply as i had not noticed that there was a response.

image as you can see 'Sep. folders' is disabled on my directory with TV shows, nor do i believe i had altered any settings between when it was still working as intended and when the issue showed up.

bugwelle commented 4 months ago

Thanks. Which version did it work with? :)

IIRC, without "Sep. folders", we don't rename any folders as we are only searching recursively for movie files, but don't assume any structure, hence no renaming of directories.

Regards, Andre

BCVerdouw commented 4 months ago

I do not know if the same problem also exists in the movie part, as for me it happened in the TV shows, the other version I can find in the cache of my package manager is 2.10.0, but i don't recall if i ever used that version, seeing as i mostly use MediaElch to batch update new entries once in a (long) while.

grimwiz commented 2 months ago

I've got the opposite problem, TV show renamer isn't renaming TV shows with this build even when I want it, for example to add the year.

bugwelle commented 1 month ago

@grimwiz Thanks for reporting. Could you share your advanced settings as well as the folder name(s) (the full path if possible)?

grimwiz commented 1 month ago

image image Here you can see a folder, "Boku no kokara no Yabai Yatsu" and the metadata should rename it to "The Dangers in My Heart (2023)" based upon the Rename Directories tickbox being ticked and the directory naming instruction set as (<year>). This worked in earlier versions of MediaElch</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>