Bug: Won't rename the folder if folder name doesnt match show.

kolbdog323 commented 2 months ago

For some reason when you have the Ignore Articles when sorting selected ("The") turned on in the settings. It won't rename the folder if the first word of the show starts with the word "The". For example i tried renaming this show The Annoying Orange from tvmaze and it wouldn't rename the folder when the Ignore articles in the settings was turned on but once i unselected it in the settings it renamed the folder.

Be nice if could rename the folder even with Ignore Articles when sorting selected ("The") if its is turned on in the settings

kolbdog323 commented 2 months ago

It doesnt do this for every show but it does do it for some of them

kolbdog323 commented 2 months ago

Sorry had to rename the bug since i noticed if the folder name wont match the tv show title it wont rename the folder it will simply refresh all the shows but it does show the proper rename in the dry run it just wont offically rename the folder and add the year. Please ignore the other bug report Sinec i noticed i had to do that for shows that dont match the offical name the renamer wont add the year or rename the folder just refreshes all the shows.

bugwelle commented 2 months ago

Thanks for reporting this issue. The renamer is a part of Mediaelch that needs to be overhauled a lot. For the time being, I won't be able to work on this issue.

kolbdog323 commented 2 months ago

Too bad i guess ill have to use filebot to properly name the files then.

kolbdog323 commented 2 months ago

I fixed it. I had to change < title > ( < year > ) to < showTitle > ( < year > ) in directory naming and it fixed the issue. Maybe for next version make < showTitle > ( < year > ) default instead of simply just ( < year >) since I looked at the renamer setting and it says this <title> is the title. but the title bracket is also used for the episode tittle. But later it the rename settings it says < showTitle > Title of Show. Which should be used for the directory naming not < title > ( < year > ). Since title is used for the episode title I think you have the flagging wrong for directory name. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/kolbdog323"><img src="https://avatars.githubusercontent.com/u/161794176?v=4" />kolbdog323</a> commented <strong> 2 months ago</strong> </div> <div class="markdown-body"> <p>Can you please fix that for future users it might help with the the directory renaming bug. changing title to showTitle for directory name.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bugwelle"><img src="https://avatars.githubusercontent.com/u/1667306?v=4" />bugwelle</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Can you please fix that for future users </p> </blockquote> <p>Sure. That was the plan. However, please note that I just don't have the time anymore: <a href="https://github.com/Komet/MediaElch/issues/1710">https://github.com/Komet/MediaElch/issues/1710</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

Komet / MediaElch

Bug: Won't rename the folder if folder name doesnt match show. #1771