Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
831 stars 93 forks source link

Support multi-part movies #548

Open zardoxnet opened 6 years ago

zardoxnet commented 6 years ago

This is for scraping movies, Movies panel I am using macOS, latest versions. MediaElch 2.4.3

Is this a known bug? Titles that have a Part 1 and Part 2, when a movie is split into 2 releases in the theater, MediaElch fails to pick up the first part when loading all movies for a directory. For example:

Harry Potter and the Deathly Hallows Part 1 (2010).mkv
Harry Potter and the Deathly Hallows Part 2 (2011).mkv

It finds only "Harry Potter and the Deathly Hallows" and from the Files location I can see it is Part 2.

NOTE: I am on Mac OS X so I cannot name the file "Harry Potter and the Deathly Hallows: Part 1 (2010).mkv" (I did try to load it with hyphen and it also did not get the Part 1.

Another example:

The Twilight Saga - Breaking Dawn Part 1 (2011).mp4
The Twilight Saga - Breaking Dawn Part 2 (2012).mp4

MediaElch finds "The Twilight Saga - Breaking Dawn" which is for the files Part 2. There is no entry for the Part 1.

After scraping a movie collection that has a part 1 and part 2 of the same movie (different years). Here is an example, I start with these (I like putting all movies in a collection in a single directory, though I know many like to put each movie into its own directory):

The Hunger Games - Catching Fire (2013).mp4
The Hunger Games - Mockingjay Part 1 (2014).mp4
The Hunger Games - Mockingjay Part 2 (2015).mp4
The Hunger Games (2012).mp4

Then after loading and scrapping I have:

clearart.png
disc.png
logo.png
The Hunger Games - Catching Fire (2013)-banner.jpg
The Hunger Games - Catching Fire (2013)-fanart.jpg
The Hunger Games - Catching Fire (2013)-landscape.jpg
The Hunger Games - Catching Fire (2013)-poster.jpg
The Hunger Games - Catching Fire (2013).mp4
The Hunger Games - Catching Fire (2013).nfo
The Hunger Games - Mockingjay Part 1 (2014).mp4
The Hunger Games - Mockingjay Part 2 (2015).mp4
The Hunger Games - Mockingjay-banner.jpg
The Hunger Games - Mockingjay-fanart.jpg
The Hunger Games - Mockingjay-landscape.jpg
The Hunger Games - Mockingjay-poster.jpg
The Hunger Games - Mockingjay.nfo
The Hunger Games (2012).mp4
The Hunger Games (2012).nfo

You can see how it failed to read that there is Part 1 and 2 and just knocked off that Part information in the title. Maybe this is some confusion with TV series scraping (though I am in the movie panel). I include the partial NFO that was created (it is for Part 2, Part 1 being ignored)

What I have been doing is manually renaming the titles that should be “Part 2” and then duplicating that file to create a set of “Part 1” and manually editing that in text editor to conform to the Part 1 details and getting art from IMDB manually.

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<movie>
   <title>The Hunger Games: Mockingjay - Part 2</title>
   <originaltitle>The Hunger Games: Mockingjay - Part 2</originaltitle>
   <rating>6.8</rating>
   <votes>5974</votes>
   <top250>0</top250>
   <year>2015</year>
   <plot>With the nation of Panem in a full scale war, Katniss confronts President Snow in the final showdown. Teamed with a group of her closest friends – including Gale, Finnick, and Peeta – Katniss goes off on a mission with the unit from District 13 as they risk their lives to stage an assassination attempt on President Snow who has become increasingly obsessed with destroying her. The mortal traps, enemies, and moral choices that await Katniss will challenge her more than any arena she faced in The Hunger Games.</plot>
   <outline>With the nation of Panem in a full scale war, Katniss confronts President Snow in the final showdown. Teamed with a group of her closest friends – including Gale, Finnick, and Peeta – Katniss goes off on a mission with the unit from District 13 as they risk their lives to stage an assassination attempt on President Snow who has become increasingly obsessed with destroying her. The mortal traps, enemies, and moral choices that await Katniss will challenge her more than any arena she faced in The Hunger Games.</outline>
   <tagline>The fire will burn forever.</tagline>
   <runtime>137</runtime>
   <mpaa>12</mpaa>
   <playcount>0</playcount>
   <id>tt1951266</id>
   <tmdbid>131634</tmdbid>
   <set>Hunger Games Collection, The</set>
   <sorttitle></sorttitle>
   <trailer>https://www.youtube.com/watch?v=YddkQoxkZMQ</trailer>
   <watched>false</watched>
   <credits>Suzanne Collins</credits>
   <credits>Danny Strong</credits>
   <credits>Peter Craig</credits>
   <director>Francis Lawrence</director>
   <studio>Studio Babelsberg</studio>
   <studio>Lionsgate</studio>
   <studio>Color Force</studio>
   <genre>Action</genre>
   <genre>Adventure</genre>
   <genre>Science Fiction</genre>
   <country>Germany</country>
   <country>United States of America</country>
   <thumb 
…. etc ...
       </streamdetails>
   </fileinfo>
</movie>
bugwelle commented 6 years ago

Thanks for reporting this.

I like putting all movies in a collection in a single directory, though I know many like to put each movie into its own directory

There's the problem. MediaElch currently does not support what you're looking for. I'll mark this as a feature request but I'm not sure when (or if) this will be implemented in the near future as I think that this is more an edge case.

I'm open for discussion. If you think that this is a must have, let me know and I'll rank it higher in my todo list :-)

zardoxnet commented 6 years ago

Close this as it is a non-issue when all movies are placed into their own folders (folder name matching movie name). The behavior I found appears to be only when all movies are together in same directory. There is no bug and no feature request. I think it is best to advise all users of this software to structure their collection of movies placed into their own folders (folder name matching movie name), do not give option to place all scrambled together in one directory -- that leads to too much confusion (and incorrect scrapes as experienced herein).