Komet / MediaElch

Media Manager for Kodi
https://mediaelch.github.io/mediaelch-doc/about.html
GNU Lesser General Public License v3.0
809 stars 94 forks source link

[NFO] [Movie] Problems with Sets (UI, nfo, images) #800

Open monisriz opened 4 years ago

monisriz commented 4 years ago

Describe the bug When scraping a Movie that is part of the "collection" on TMDb, only the collection name is scraped correctly. This is displayed on the main "movie" pane next to the label "Set". The nfo file also has this set name populated correctly:

    <set>
        <name>The Avengers Collection</name>
        <overview></overview>
    </set>

This set name is parsed from the movie search result:

"belongs_to_collection": {
        "id": 263,
        "name": "The Dark Knight Collection",
        "poster_path": "/bqS2lMgGkuodIXtDILFWTSWDDpa.jpg",
        "backdrop_path": "/xfKot7lqaiW4XpL5TtDlVBA9ei9.jpg"
    }

The overview tag in the nfo however is never populated as there is no set overview in the original response. In order to get the overview tag a call needs to be made to the "/collection/{collectionId}" endpoint which has the proper/complete details of a given set (movies in the set, poster, backdrop, etc). See: https://developers.themoviedb.org/3/collections/get-collection-details

Moreover, in the Sets view, only the Set name and names of the movies part of the set are displayed. There are placeholders for set related images but clicking them doesn't do anything at all. The list of images for a given set can also be fetched using "/collection/{collectionId}/images" endpoint. Similarly, overview can be displayed in the Sets section UI as well to further make this section useful.

MediaElch Version:

bugwelle commented 4 years ago

What needs to be done to close this issue? (reminder for myself):

monisriz commented 4 years ago

Scraping of collection artwork (poster/fanart) needs to be added too. The placeholders in set window are not populated and clicking the placeholders doesn’t fetch any images either.

ticao2 commented 4 years ago

Kodi informs that v18 can't add local art, to do this Kodi claims to need the Artwork Beef add-on; Kodi informs us that v19 will incorporate the Artwork Beef add-on method; I ask: wouldn't it be easier to adopt this method already adopted by Artwork Beef? https://kodi.wiki/view/Movie_sets_artwork

,,, a central movie set folder with sub-folders for each movie set. This method will be used for v19.

If there will be a folder for each collection with your art files, how about creating an NFO file for each collection?

I wonder when you add a new movie to the collection and this new one has other overview text and other poster and fanart images.

I personally prefer the "sub-folder" of the collection to be specified, determined, chosen. I can choose any folder in my movie library. For example, in the Sci-Fi folder there is a Star Wars folder with all the movie folders and ... with all the arts in this collection. And the new NFO. :-)

I think I've said too much.

monisriz commented 4 years ago

I don’t think kodi needs or supports any nfo files for “sets” or collections as you call them.

As for the overviews, set/collection overview is different than the overview for individual movies. All movies in a given collection share the same collection overview scraped from TMDb. All NFO files for movies in a given set will have same set overview written under the tag which is different than the tag which is for movie-overview.

ticao2 commented 4 years ago

Hi @monisriz

I don’t think kodi needs or supports any nfo files for “sets” or collections as you call them.

Yes, I know that Kodi does not support. I imagined a CollectionName.NFO for MediaElch use only. It would be a file to consolidate information from a collection.

As for the overviews, set/collection overview is different than the overview for individual movies. All movies in a given collection share the same collection overview scraped from TMDb.

Yes, I also know that a Collection Overview is not the same as the Overview of any of the movies in this collection. I have already added in some TMDb Collections the Overview text in pt-BR.

All NFO files for movies in a given set will have same set overview written under the tag which is different than the tag which is for movie-overview.

`


` https://kodi.wiki/view/Movie_sets

My question is: If we already have movies from a collection, for example Star Wars, all with the Collection Overview in their respective NFOs; So let's add one more movie to the collection, but the Overview has been modified in TMDb; What should happen? Update Overview text in all NFO files of older movies. What if this is not possible? Previous movies are no longer on MediaElch, they are all on another computer. When this new movie is added to Kodi, Kodi will have this latest movie with a Collection Overview with different text. What text will Kodi use? NFO text with most recent date? These are just some of my doubts.

bugwelle commented 3 years ago

For reference: https://github.com/Komet/MediaElch/issues/1129#issuecomment-753643809