Colorpicker: return the color that has been actually changed

Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.

http://www.komodoide.com/komodo-edit

Other

2.15k stars 301 forks source link

Colorpicker: return the color that has been actually changed #2033

Open Defman21 opened 8 years ago

Defman21 commented 8 years ago

Short Summary

If you click on a hex color, but then focus on hsl, change the color and press OK, hex will be changed to... hex. It should be replaced with an actual hsl color.

Platform Information

Komodo Edit or IDE? IDE Komodo Version? 10.1 nightly Operating System (and version)? Ubuntu 16.04

Additional Information

I can send a PR to fix that :)

Defman21 commented 8 years ago

It would require to re-work aCallback in https://github.com/Komodo/KomodoEdit/blob/master/src/chrome/komodo/content/colorpicker/xpcom_colorpicker.js#L139 Not something I have knowledge about.