search

Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
http://www.komodoide.com/komodo-edit
Other
2.14k stars 299 forks source link

cant move default color picker #2036

Closed babobski closed 7 years ago

babobski commented 7 years ago

Short Summary

If you have a color at the bottom of you're window, and you trigger the colorpicker. You're unable to move the color picker, so you can't access the buttons.

Platform Information

Komodo Ide 10.1.1 Windows 10

Defman21 commented 7 years ago

ColorPicker is a <window> object so you should able to move it. It works on Linux.

babobski commented 7 years ago

2016-09-22 14_31_08- Had the same problem problem with the rgba colorpicker with the implementation of the xul wrapper. It uses a dialog, witch I cant move on windows, to fix it I had to change it into a window.

Defman21 commented 7 years ago

Try to use native decorations? If they are working, so you probably won't be able to move any dialog in Komodo without native decorations.

UPD: sorry, the built-in color picker uses <dialog>.

babobski commented 7 years ago

When using native decorations I can move the color picker. When I'm not using native decorations, there are windows I can move ( like the preferences window, project preferences ) and there are windows that cannot be moved like the properties of a toolbox-item. And the run command window doesn't use a xul wrapper.

Defman21 commented 7 years ago

None of these you named are using <dialog> except for properties of a toolbox item.

Also you're missing the meaning of xul wrapper - it's being used to wrap HTML so it could access XUL itself (chrome:// urls, Less, etc.). You should be able to move Run Command window because it's a window, not a dialog.

babobski commented 7 years ago

You should be able to move Run Command window because it's a window, not a dialog.

Added the note for the run command, because it's missing the decorated border, it's already using native decoration. 2016-09-22 15_06

Naatan commented 7 years ago

There are definitely some dialogs that cannot be moved. These should pretty much exclusively be modal dialogs. I'm not having any issue moving the color picker one when native decorations are disabled. @cgchoffman could you test on Windows? I only have access to OSX today :\

th3coop commented 7 years ago

Confirmed @babobski bug: I can't move color picker on Windows with native decorations disabled.

Defman21 commented 7 years ago

This is Windows only. I can move dialogs without native decorations.

Defman21 commented 7 years ago

1621 could be related to this.

babobski commented 7 years ago

Looks like it's the default behavior for a dialog on windows. If I look at the dialogs under https://github.com/Komodo/KomodoEdit/tree/master/src/chrome/komodo/content/dialogs all the windows that are using "dialog" I can't move. alert.xul, compare.xul, iconpicker.xul are all using the "dialog" type and I can't move any of them.

Defman21 commented 7 years ago

It's a bug. It would be an excepted behavior if it would behave in the same way across all systems (OSX, Linux, Windows).