search

Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
http://www.komodoide.com/komodo-edit
Other
2.14k stars 299 forks source link

Updates added files can't be removed by Windows uninstall #2192

Open babobski opened 7 years ago

babobski commented 7 years ago

Short Summary

Just had to uninstall komodo 10.1.2 (), but i was unable to install komodo in the default install directory "ActiveState Komodo IDE 10". Because the directory still exists and was not empty, renamed it to "ActiveState Komodo IDE 10.1" to run the installation.

Steps to Reproduce

Uninstall komodo 10.1.2 windows 10

Expected results

Komodo is removed, so the install directory should no longer exist or at least should be empty so I can re-install komodo without having to choose a different install directory.

Actual results

The directory still exist with the lib folder still inside, so you will have to choose a different install directory.

Platform Information

Komodo Ide 10.1.2 Windows 10

th3coop commented 7 years ago

Can you confirm this happens with a fresh install? The uninstaller only removes the files it knows about so if you've changed your install dir it won't remove everything. If you modified the install dir then this is expect...and given it's you @babobski, i suspect that might be the case. Not a bad thing ;)

babobski commented 7 years ago

I just uninstalled komodo at home, but here i have the same problem: 2016-11-29 17_45_22 When installing Komodo Ide 10.1.1 I can not install Komodo again because the default directory is not empty.

I already removed Komodo before installing 10.1.1 only I can not reinstall komodo because the lib folder is not removed.

2016-11-29 17_49_53

If you modified the install dir then this is expect

I only used the change button in the install screen so I could install Komodo Ide 10.1.1 again, because I was not able to install in the default directory. Here at home I just removed the lib folder so i could install komodo in it's default directory

th3coop commented 7 years ago

I can't tell if you followed my suggestion or not. This is due to you changing the contents of lib. There is nothing we can do about that. The uninstaller is only allowed to remove files that it knows about, ie. the files it installed in the first place.

babobski commented 7 years ago

Can you confirm this happens with a fresh install?

I was a bit confused,what you meant with this. But just uninstalled komodo 10.1.1 then the issue does not appear.

I then remove Komodo again and restored the lib folder. But when I look inside these are not changes I made, but these changes are made by komodo.

The folders/files that where left behind are:

2016-11-29 19_29_11

2016-11-29 19_31_05

2016-11-29 19_31_53

2016-11-29 19_32_19

2016-11-29 19_34_07

2016-11-29 19_34_48

2016-11-29 19_35_21

2016-11-29 19_35_52

2016-11-29 19_36_49

th3coop commented 7 years ago

Well that's helpful. @Naatan comments that all of those files were added by updates. So I was half right. Komodo update added files and the uninstaller doesn't know about them do it doesn't remove them.

Not sure what the solution is here. I don't think the moz update mechanic has the ability to update Windows on what's been added...but I haven't looked into it. That will come later.