Changebar always shown in every Chinese comment

[ghost]

Short Summary

Changebar always shown in every Chinese comment

Steps to Reproduce

Python code with Chinese comment charset: utf-8

Expected results

No changebar shown in every Chinese comment

Actual results

Changebar always shown in every Chinese comment, even after a commit action. Click the changebar ,old line is gibberish and new line is normal

Platform Information

Komodo Edit or IDE? IDE Komodo Version? 10.2 Operating System (and version)? Win 10

Additional Information

[mitchell-as]

Hi, thanks for the report. Would you please attach a file that contains a Chinese comment that exhibits the problem? (It doesn't have to be the entire file.) An attachment is preferred, as pasting a snippet into a Github comment may mangle it in some way. Thank you.

[ghost]

chinese comment.txt

[mitchell-as]

@cgchoffman Can you reproduce this on your Windows machine? On Linux I cannot. I suspect it's a Windows encoding-type of issue.

[th3coop]

No issue for me. I'm assuming we're talking about the Track Changes column in the scintilla gutter? Track changes behaved as expected.

The filed opened as UTF-8.

[ghost]

Operating System (and version)? Win 10 Chinese version. Maybe this is the cause.

[Naatan]

@glados01 is your file encoding set to UTF-8?

[ghost]

@Naatan Yes

[Naatan]

What version control system are you using (if any)?

[ghost]

git version 2.11.0.windows.1

[Naatan]

I just tried the following in a new directory with the file you supplied in it

git init
git add chinese-comment.txt
git commit -m first

Then I opened the file in Komodo and it's showing no modifications. Do those steps reproduce the issue for you?

[ghost]

Yes

[Naatan]

Does running gif diff on a file that's showing changes in Komodo produce anything?

[ghost]

@Naatan No.

[Naatan]

We'll see if anything stands out in the code as being problematic.

[ghost]

Komodo IDE 11 still has the issue, and chinese characters in show changes dialog are gibberish too.

[mitchell-as]

Hi, this issue has not been resolved yet, so the behavior originally described would still exist. Thanks for your patience.

[ghost]

I think it is about os and Git function. Since you don't have Chinese Win10, so you can't reproduce it.

[Naatan]

Does git diff show a difference in the file too?

[ghost]

You mean in Git Bash? No. But Git diff in Git Bash show Chinese characters as below, and the Chinese characters are normal in Git gui.

<96><95>E.4<94><9A><84>MA<9A>

<84><91><9C><9F>

[Naatan]

You say the issue happens after a commit, does that mean you need to have made the actual change in question first, then committed it? Or does it happen on all comments in a file regardless of whether they have been changed in the commit?

[ghost]

I mean the issue is always there, even after a commit. Track changes bar and show changes dialog just can't handle Chinese characters correctly.