search

Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
http://www.komodoide.com/komodo-edit
Other
2.16k stars 302 forks source link

Color Scheme Editor does not ask to fork a built-in scheme when editing its CSS #2478

Open Defman21 opened 7 years ago

Defman21 commented 7 years ago

Short Summary

When you want to edit a built-in scheme, you have to fork it (Komodo will ask for it). However, this does not happen when you simply change its CSS.

Platform Information

Komodo Edit or IDE? IDE Komodo Version? latest nightly Operating System (and version)? elementary OS 0.4

Naatan commented 7 years ago

Doesn't look like this affects the color scheme in any way, it just is missing the warning so the user doesnt know what's going on.

th3coop commented 7 years ago

Doesn't look like this affects the color scheme in any way, it just is missing the warning so the user doesnt know what's going on.

What do you mean? If the CSS isn't saving then it definitely effects the colour scheme.

Naatan commented 7 years ago

How does it not saving affect the color scheme

Defman21 commented 7 years ago

It doesn't affect the default color scheme, Carey. It won't break the scheme or something, the problem is in the UX. Komodo should ask for a fork of the scheme when the user edits its CSS so the changes won't lost.

th3coop commented 7 years ago

If it's in the same dialog and they save at the same time i would consider the CSS as part of the colour scheme so in that sense, the color scheme is broken if I can't save it. I guess you guys mean the dialog is broken. Same diff.

th3coop commented 7 years ago

We all agree on the solution to fix it, so ya...