Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
http://www.komodoide.com/komodo-edit
Other
2.16k stars 302 forks source link

Empty popup version check #3158

Open babobski opened 7 years ago

babobski commented 7 years ago

Short Summary

This morning I started up Komodo X and got the Komodo 11 release popup. Noticed a while later that I'm having a empty notification:

afbeelding

If I inspect the window witg the DOM inspector I can see it's has ?name=versioncheck in the url:

afbeelding

Platform Information

[2017-09-26 08:45:41,959] [INFO] Startup: Welcome to Komodo IDE 10.2.3 build 89902 (platform win32-x86, running on Windows post2012Server version 6.3.9600)

Naatan commented 7 years ago

Bah, that really sucks. Thank you for sharing.

Naatan commented 7 years ago

Hmm just tried this on Windows and was not able to reproduce. What could be different about your setup?

babobski commented 7 years ago

@Naatan I think I know what is going on, I clicked on the "not interested" button. Only the click did not work, the popup is moved behind the main window, when I open the popup trough the windows taskbar and click the second time it's working. Rebooted a few times of the sql bug, but noticed the this popup was still coming up. So I noticed the behavior that It's not actually closing the popup but moving it behind the main window.

Why it has become empty, I dont know.

Just tested it at home, but cant repo this bug.

babobski commented 7 years ago

The only thing I can think of, is that at work I have multiple monitors. Maybe a that It's some kind of focus bug related to that.

Is there a pref that I can set back to get the popup again, for some more testing?

Naatan commented 7 years ago

Yes, you can delete it with

require("ko/prefs").deletePref("versioncheck.dontask.10"). You can also manually invoke the versioncheck with ko.launch.newVersionCheck()

babobski commented 7 years ago

Thanks, did some testing at home, but found a way to empty the version check screen.

The version check screen is now empty.

afbeelding

Because at work the I noticed later on the screen was still open, in the time the window was open. It's assumable that I opened and closed a Komodo window.

I'm pretty sure I hit the button 2 times and the third time I was aware of the window getting out of focus. So I re-focused it and clicked the button, after that the window did not appear again. (but I almost opened a issue for the screen keeping popping, while I clicked the 'not interested' button). I will check tomorrow if I can reproduce the "focus" issue and report back.

Naatan commented 7 years ago

Thanks @babobski !

babobski commented 7 years ago

I did not get to test the focus issue today, was a bit hectic. But gave it some thought's, but if the focus issue exist, you can simply fix (both) issues by adding the modal feature to the window features. This will automatically prevent the window to get behind the main window, also you cant close or open a new Komodo window ( maybe only using shortcuts ), you need to close the version check screen first.

The focus bug I will test tomorrow.

babobski commented 7 years ago

@Naatan tested this today at work, but I'm unable to reproduce the focus issue.

Naatan commented 7 years ago

Thanks @babobski, very helpful :)