Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
http://www.komodoide.com/komodo-edit
Other
2.16k stars 303 forks source link

save not working #3717

Open Lunardog15 opened 5 years ago

Lunardog15 commented 5 years ago

Edit: Updated repro steps from a comment below in this ticket

I have found steps to reproduce the issue step 0 set the Komodo browser preview to separate dialog step 1 create 1 html5 file step 2 open in Komodo browser preview step 3 modify the file and save step 4 close the Komodo browser preview step 5 modify the file and save expected behavior: saves actual behavior : wont save

 TypeError: can't access dead object

Exception: TypeError: can't access dead object

Traceback:
_doSave@vieweditor:1286:1
save@vieweditor:1406:28
viewManager.prototype.do_cmd_save@chrome://komodo/content/views.js:1595:5
xtk.Controller.prototype.doCommand@chrome://xtk/content/controller.js:91:9
command_doCommand@chrome://komodo/content/library/commands.js:272:1
command_doCommandAsync@chrome://komodo/content/library/commands.js:224:1
@chrome://komodo/content/keybindings/keybindings.js line 2533 > eval:1:1
this.Manager.prototype.evalCommand@chrome://komodo/content/keybindings/keybindings.js:2533:23
this.Manager.prototype.keypressHandler@chrome://komodo/content/keybindings/keybindings.js:2702:17
gKeyHandler@chrome://komodo/content/keybindings/keybindings.js:2588:5

Komodo Edit, version 11.1.0, build 18196.
Built on Wed May 23 00:44:25 2018. 

is there some type of fix I can do manually for the time being or is this a thing that has to be solved by reinstalling / updating I am unable to update as I do not have admin permissions and would have to talk to our IT person

th3coop commented 5 years ago

@Lunardog15, please share your full logs, Help > Troubleshooting > View Log File. Please also try in safe mode, Help > Troubleshooting > Restart in Safe-Mode

Lunardog15 commented 5 years ago

ok pystderr.log also it only happens some times.

th3coop commented 5 years ago

@Lunardog15 that error is not in the logs your share. Did you reproduce the issues before sending the logs?

When it does occur can you narrow down what changed in your work flow or about the file you're working on or anything else that could contribute to the issue? Try to narrow this down a bit. Komodo 11.1.0 has been out for a while now and no one else is hitting this issue so can you think of something that has changed on your system recently that we could investigate?

Lunardog15 commented 5 years ago

Sorry, I did in fact forget to reproduce the bug. It seems to save normally the fist time, but the second time I save, it breaks. This is happening with HTML files.

th3coop commented 5 years ago

Sorry, I did in fact forget to reproduce the bug.

K, sounds like it's pretty easy to reproduce. Could you reproduce it and resend your logs? And if it's pretty straight forward to reproduce, can you try it in Safe Mode? You could also do a more permanent reset of your Komodo profile (which is what safe mode is but temporary):

If it doesn't return, try adding things back to your profile like the tools folder, and reinstalling any addons you might have added.

Lunardog15 commented 5 years ago

oddly enough when trying to reproduce it I was unable to have this happen It may have something to do with the time between saves and modifications to the file. possibly a timeout issue or something? Im going to work and see if it happens again

th3coop commented 5 years ago

possibly a timeout issue or something?

@Lunardog15, is a remote file?

Lunardog15 commented 5 years ago

no it is a local file

Lunardog15 commented 5 years ago

I also just got this (possibly related?) problems

th3coop commented 5 years ago

@Lunardog15 possibly. It doesn't help us track down the issue though :) We need the logs or reproduction steps. The feature you're showing in your screenshot is maybe a result of the failed save but that wouldn't explain why the failed save happened.

Lunardog15 commented 5 years ago

it seems to have fixed its self but I am not sure why should this be marked as closed?

th3coop commented 5 years ago

We can leave it open in case others hit this issue but please understand I can't justify working on this issue with no reproduction steps and no other users hitting it.

Lunardog15 commented 5 years ago

ok, I will get back to you if something happens thank you for trying to help

Lunardog15 commented 5 years ago

I have found steps to reproduce the issue step 0 set the Komodo browser preview to separate dialog step 1 create 1 html5 file step 2 open in Komodo browser preview step 3 modify the file and save step 4 close the Komodo browser preview step 5 modify the file and save expected behavior: saves actual behavior : wont save

th3coop commented 5 years ago

@Lunardog15 you're gonna hate me but...i still can't reproduce this. Did you confirm the steps in Safe-Mode?

Lunardog15 commented 5 years ago

no not yet I will try it in safe mode

Lunardog15 commented 5 years ago

before i forget here are the logs pystderr.log

Lunardog15 commented 5 years ago

Ok some how I managed to get the browser preview thing in a separate window which seems to cause the issue. not sure how I did that but I hope that helps

Lunardog15 commented 5 years ago

yeah it's the separate dialog setting that breaks it

Lunardog15 commented 5 years ago

@cgchoffman confirmed in safe mode that the separate dialog setting that breaks it

th3coop commented 5 years ago

@Lunardog15 Thanks for all the digging. I'll have to take another look at this badboy and see if I can get it.

Lunardog15 commented 5 years ago

Thank you

th3coop commented 5 years ago

Finally! Man...nice find @Lunardog15. If you prefer previewing in a separate dialog I suggest using an installed browser instead.

th3coop commented 5 years ago

PS. you set the separate dialog pref in the Web & Browser preferences.

Lunardog15 commented 5 years ago

thank you