Python syntax checking: Change the way of checking that pep8 ran well

Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.

http://www.komodoide.com/komodo-edit

Other

2.15k stars 301 forks source link

Python syntax checking: Change the way of checking that pep8 ran well #3861

Closed 51CGO closed 4 years ago

51CGO commented 4 years ago

pep8 displays a warning when it runs. This warning is printed on stderr, so Komodo acts as if pep8 returned an error. To make pep8 work again, I changed just one thing: Komodo does not check pep8 stderr anymore but it checks the return code of pep8.

See https://github.com/Komodo/KomodoEdit/issues/3860

51CGO commented 4 years ago

I'm approving but heads up, if you are to do another PR for something, please don't include 24 lines of formatting. We don't even accept that in internal PRs unless that's the point of the PR.

Understood ! My Komodo is configured to deleted trailing spaces. I'll disable this functionality next time. :)