search

Komodo / KomodoEdit

Komodo Edit is a fast and free multi-language code editor. Written in JS, Python, C++ and based on the Mozilla platform.
http://www.komodoide.com/komodo-edit
Other
2.15k stars 301 forks source link

Add argument "--version" to docklet run #3870

Closed 51CGO closed 4 years ago

51CGO commented 4 years ago

Hi,

When building Komodo, users have to specify version for mozilla build and komodo build. But when using Docker, there was no option to docklet run to specify the version to run.

th3coop commented 4 years ago

This doesn't look right to me but I also haven't used or looked at the docker build process. @Naatan maybe you could weigh in.

Naatan commented 4 years ago

The diff look sane but frankly there's really no reason to be building with any other version at this stage, least that I can think of? What's your use-case @crigoda ?

51CGO commented 4 years ago

Well, here's what happened to me: Working on #3872, I followed the old readme to build Komodo so I build Mozilla and Komodo with version 10.10 as written in the readme... When I tried to run it, the docklet did not find the directories because the version is hard-coded in the docklet script. As it's possible to specify the version at build time, this should be possible to specify it at run time :)

Naatan commented 4 years ago

I'm afraid the solution there is to rebuild with 12.10. Building a 12.10 build with a 10.10 version specifier can lead to unexpected results (eg. pref updater not updating certain prefs that need to be updated for v12 to operate).

I'm sorry, you'll have to rebuild :\ I'll reject this PR since the use-case is not valid, but I appreciate your contribution!

51CGO commented 4 years ago

OK. This is not a big thing. But maybe something has to be done to build automatically the good version of Mozilla and Komodo according to the version specified in the docklet...

Now I know that I must check the docklet before building. :-/