KomodoHQ / komododigital.co.uk-frontend

Our New Website!
https://komodohq.github.io/komododigital.co.uk-frontend/
MIT License
3 stars 2 forks source link

Implement a video title section on the homepage. #131

Closed Jason2605 closed 4 years ago

Jason2605 commented 5 years ago

Currently the homepage has a static image for the title section. This PR changes this image to a short video. This PR also embeds the showreel image into the homepage as well instead of opening a new tab linking to Vimeo.

Closes #101 Closes #102

drewmiley commented 5 years ago

@Jason2605 Made a small change to the padding-bottom on small screen widths. This appears to fix whitespace issues on devices

Jason2605 commented 5 years ago

@drewmiley Unfortunately these changes have caused an issue where you need to scroll to view the video on mobile devices. This shouldn't be the case. Instead in landscape mode the video should fill the screen (or on bigger devices a portion of the screen) and a user should never have to scroll to view the video.

Worth noting this is in regards to the "watch showreel" section.

drewmiley commented 5 years ago

This causes an issue on the client stories pages where the index area of a client story no longer has a straight line at the bottom.

kmd-thomasBrace commented 5 years ago

Fixed issue with whitespace on small devices without having the user to have to scroll down when in landscape

onion2k commented 4 years ago

Website is on SquareSpace now. This isn't needed any more.