search

KomodoHQ / komododigital.co.uk-frontend

Our New Website!
https://komodohq.github.io/komododigital.co.uk-frontend/
MIT License
3 stars 2 forks source link

Integrate Contact Forms #75

Closed ianoshorty closed 6 years ago

ianoshorty commented 6 years ago

Using formspree, we have working contact forms! Closes #61

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/component_layout@bbda150). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             feature/component_layout      #75   +/-   ##
===========================================================
  Coverage                            ?   93.23%           
===========================================================
  Files                               ?       32           
  Lines                               ?      207           
  Branches                            ?        6           
===========================================================
  Hits                                ?      193           
  Misses                              ?       11           
  Partials                            ?        3
Impacted Files Coverage Δ
src/components/contactform/index.tsx 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbda150...25890d9. Read the comment docs.

ianoshorty commented 6 years ago

Formspree doesn't seem very secure. I imagine it's checking the email address that's sent to it, and maybe the referrer, but that would be trivial to get around. If we have a paid account we could replace the email address with a key which would certainly help.

Theres a "first step" validation which requires a submission source and destination be approved in order to continue receiving. I've already done this for localhost > hello@. Indeed the paid account will allow us to mask the email address, and we can definitely sign up for this, but its a 2 second change that can be done during swap-over to production config.

Also, there's no validation or user help on the forms you've added here. I guess these are just placeholders for the time being, but I imagine Matt won't see it that way... Maybe we should hold off integrating this in to develop until we have forms that are what we want them to be?

Yep, they are just placeholders, but adding validation and styling will take little time. Its OK to merge.