KomodoOpenLab / tecla-framework

This repo is now deprecated, please move on to https://github.com/idrc/tecla-hud
http://komodoopenlab.com/tecla/
2 stars 9 forks source link

Shield Service calls are being made to the TeclaSettingsApp through a secondary instance #392

Closed ijdoc closed 11 years ago

ijdoc commented 11 years ago

This is just plain wrong! The shield manager should not be instantiated in any class that has a finite life cycle because we are never sure whether the instance actually exists!

Instances of services that are referred/bound to from any other class should only exists in services that are guaranteed to always be available as long as the Tecla app is running. The only class that ensures this is the main Application class (i.e., TeclaApp)

cc @k22mak