KomodoOpenLab / tecla-framework

This repo is now deprecated, please move on to https://github.com/idrc/tecla-hud
http://komodoopenlab.com/tecla/
2 stars 9 forks source link

Instance of settings activity in TeclaApp class should be removed #393

Closed ijdoc closed 11 years ago

ijdoc commented 11 years ago

The settingsactivity instance has a finite life cycle and should therefore not be instanciated in the TeclaApp permanent service. This is a bad practice that may cause random issues as it becomes necessary to track whether the instance exists or not.

see this line in TeclaApp class: public static TeclaSettingsActivity settingsactivity; //FIXME: why do we need an "always on" instance of an activity with a finite life cycle?

cc @k22mak