KomodoPlatform / atomicDEX

This is the official AtomicDEX mobile (smartphone app) repository
https://atomicdex.io
GNU General Public License v2.0
10 stars 15 forks source link

Amount displaying not correct in transaction info in case with rewards (negative txfee) #158

Open dth88 opened 4 years ago

dth88 commented 4 years ago

Looks like AtomicDEX calculating transaction amount as amount - fee or something like that

Actual transaction:

https://kmdexplorer.io/tx/d8fb5e8ab65b24f1e1c237778af0e6690faff617ccdd0a7799955349f8ae9c69

Now in AtomicDEX txinfo in such case looks not clear (like I sent 0.58 KMD instead of 1)

Imo in case of tx with rewards usage we just need to display the amount of sending to destination vout as a number on top in AtomicDEX so it'll be clear like now in explorer.

image image

--upd: Maybe we can put a destination vout amount as an amount? (it should be the same total as amount + fee but exactly precise) Such amount+fee backward summarizing might create a precision issue imo

--upd: Little bump. Re-read that and thought more from user perspective (especially user who don't know KMD rewards specifics) it looks like a bug Imo we should treat txs with KMD rewards with little special love to clearly show what amount he sent, what rewards he received, and what was tx fee. Now displayed information is just not correct

Duplicated from private repo: https://github.com/ca333/komodoDEX/issues/428