search

KomodoPlatform / atomicDEX

This is the official AtomicDEX mobile (smartphone app) repository
https://atomicdex.io
GNU General Public License v2.0
10 stars 15 forks source link

Total asset display #82

Open christian-silvestre-74299963 opened 5 years ago

christian-silvestre-74299963 commented 5 years ago

IOS and android version 0.1.6

Total asset display includes NOT yet CONFIRMED transactions (sometimes double quantity during a consecutive swap) this is hard to reproduce during swaps but this happens

tonymorony commented 5 years ago

@dudezmobi please elaborate with some at least approximate reproduction steps (what we need to do to reproduce, what we should expect and what is actually happening)

christian-silvestre-74299963 commented 5 years ago
  1. Swap needs to finish until step 3. (ex. ETH to KMD)
  2. Go back to PORTFOLIO total assets displayed in USD
  3. The total USD value displays the PREVIOUS USD value PLUS the swapped asset which was not yet confirmed.

suggestion: after any swap (step 3) wait for ALL transactions to be confirmed before computing for total USD value

tonymorony commented 4 years ago

Balances fetching process was re-factored @dathbezumniy could you please check if this one is actual on last version of mobile GUI?

dth88 commented 4 years ago

@tonymorony just finished with this test on iOS (KMD<=>RFOX), the good news is that no weird total assets value fluctuations were noted on any stage of the swap but at the end of the swap (Stage 3 I suppose), the unconfirmed transaction was indeed put in the total asset value before it was confirmed. So the issue is still there if it was about the unconfirmed transaction being in the total asset pool. But no double quantities or anything weird like that.

tonymorony commented 4 years ago

Thanks for the research @dathbezumniy 👍 it looks like a feature request for confirmed / unconfirmed balances separation, lets keep this one