Minu coin listing request

the atomic swap will fail if output amount != input amount, eg because a part of it is sent as fee to a different address (that's what ARRR-BEP20 was doing) but i can do a test if you send me some tokens to 0x15C577f4b9fbe66735A9bFF9B0B5D3EA2854Bfaa

LeonaOperation commented 4 months ago

As I understand you accept token without fees on BUY and SELL transaction.Or I'm wrong? Minu has 5% fee on buy and 5% fee on every sell. This is the problem?

cipig commented 4 months ago

an atomic swap is done in 5 txes, like this:

[Taker Fee (ETH)](https://etherscan.io/tx/0xab91431056968661374e2740dad98960033ff284d510343867213f111c4c44c0)  
[Maker Payment (KMD)](https://kmd.explorer.dexstats.info/tx/2ce42b3c370c904ce1fdb6a16e72c0ac48988174673f4e882e8a7893cbf058cd)  
[Taker Payment (ETH)](https://etherscan.io/tx/0xfd3fd8b5e115ac76c9e3895b89c704508632a6b6672f452fd8a0c8ed7853d947)  
[Taker Payment Spent (ETH)](https://etherscan.io/tx/0xd40160a0c7434ef6b0b03cc2860a1b8effe13b48e30c30bec52014d24aedb990)  
[Maker Payment Spent (KMD)](https://kmd.explorer.dexstats.info/tx/0af509746ecddfd1cc339b757b0bb6154059948e2b1b97a4afb0a1a539075636)

so eg taker sends takerpayment of 100 MINU and maker will later try to spend exactly 100 MINU from the swap contract address... but if there is a fee in the MINU contract that sends a part of the 100 MINU to some other address, then maker will not able to spend 100 MINU and the swap will fail

but idk the implementation of this fee part, just saw it on de.fi/scanner and assumed that it's similar to ARRR-BEP20 i can try, maybe it works... if it doesn't work we can add MINU as wallet-only, then it can be only used in wallet mode, not for swapping on the DEX

LeonaOperation commented 4 months ago

Thank you try and if work let us know.We will be happy also with wallet integration as well!

cipig commented 4 months ago

can you please send me some MINU-BEP20 to 0xF2ed2aC92489106c942c9e32c6A912ba61aF93E3, so i can test a swap?

LeonaOperation commented 4 months ago

Send you BNB to buy that. Here is the TXN: 0x84532bfd5c14db056d995f4d04723ece46d5b74a27801d91d115d933a456ee02

LeonaOperation commented 4 months ago

can you please send me some MINU-BEP20 to 0xF2ed2aC92489106c942c9e32c6A912ba61aF93E3, so i can test a swap?

So ?

cipig commented 4 months ago

tried to swap MINU-BEP20 for KMD, but the takerpayment tx failed: https://bscscan.com/tx/0x6c5945840835d3327736e2d144252fe444189b7fadaa55dd4b1c9f15b9d50770

LeonaOperation commented 4 months ago

What do you advise to do now?

LeonaOperation commented 4 months ago

an atomic swap is done in 5 txes, like this:
[Taker Fee (ETH)](https://etherscan.io/tx/0xab91431056968661374e2740dad98960033ff284d510343867213f111c4c44c0)  
[Maker Payment (KMD)](https://kmd.explorer.dexstats.info/tx/2ce42b3c370c904ce1fdb6a16e72c0ac48988174673f4e882e8a7893cbf058cd)  
[Taker Payment (ETH)](https://etherscan.io/tx/0xfd3fd8b5e115ac76c9e3895b89c704508632a6b6672f452fd8a0c8ed7853d947)  
[Taker Payment Spent (ETH)](https://etherscan.io/tx/0xd40160a0c7434ef6b0b03cc2860a1b8effe13b48e30c30bec52014d24aedb990)  
[Maker Payment Spent (KMD)](https://kmd.explorer.dexstats.info/tx/0af509746ecddfd1cc339b757b0bb6154059948e2b1b97a4afb0a1a539075636)  
so eg taker sends takerpayment of 100 MINU and maker will later try to spend exactly 100 MINU from the swap contract address... but if there is a fee in the MINU contract that sends a part of the 100 MINU to some other address, then maker will not able to spend 100 MINU and the swap will fail

but idk the implementation of this fee part, just saw it on de.fi/scanner and assumed that it's similar to ARRR-BEP20 i can try, maybe it works... if it doesn't work we can add MINU as wallet-only, then it can be only used in wallet mode, not for swapping on the DEX

Ok understand the problem.Move with the wallet integration and let us know so we will make some announcements in our socials media!

cipig commented 4 months ago

did the PR https://github.com/KomodoPlatform/coins/pull/1002 with Minu as wallet_only after merge every new GUI release will have Minu this is btw the tx of a simple transfer of Minu to other address with Komodo Wallet: https://bscscan.com/tx/0x3cebaa3b3351041a6dac49457968df6c361ab60a223a40ea9a529c827de340ce

LeonaOperation commented 4 months ago

did the PR #1002 with Minu as wallet_only after merge every new GUI release will have Minu this is btw the tx of a simple transfer of Minu to other address with Komodo Wallet: https://bscscan.com/tx/0x3cebaa3b3351041a6dac49457968df6c361ab60a223a40ea9a529c827de340ce

The TXN looks perfect.We should download from here to see Minu inside with the logo?

LeonaOperation commented 4 months ago

did the PR #1002 with Minu as wallet_only after merge every new GUI release will have Minu this is btw the tx of a simple transfer of Minu to other address with Komodo Wallet: https://bscscan.com/tx/0x3cebaa3b3351041a6dac49457968df6c361ab60a223a40ea9a529c827de340ce

The TXN looks perfect.We should download from here to see Minu inside with the logo?

https://komodoplatform.com/en/wallets.html From this link?

cipig commented 4 months ago

the PR needs to be merged first, then a release be made with this changes i have started a build with Minu in my own repo: https://github.com/cipig/atomicDEX-Desktop/actions/runs/8118628546 so if you want to try dowload from there... build takes 1h and will be only visible if you are logged in to github

LeonaOperation commented 4 months ago

Hello,

Let us know when it is complete so we will prepare some announcements! Thank you

Στις Κυρ 17 Μαρ 2024 στις 1:19 π.μ., ο/η cipig @.***> έγραψε:

Closed #1001 https://github.com/KomodoPlatform/coins/issues/1001 as completed via #1002 https://github.com/KomodoPlatform/coins/pull/1002.

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#event-12141206807, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK4ZYYOPZKYBNBYOQZ3YYTHOJAVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGE2DCMRQGY4DANY . You are receiving this because you commented.Message ID: @.***>

cipig commented 4 months ago

The PR was merged. Official Desktop will have it when a new release is published in https://github.com/KomodoPlatform/komodo-wallet-desktop/releases Mobile already has it because it gets latest config from github on each start, but it is missing a logo, since that is integrated in the binary, so it will only show a logo when a new release is published there too.

LeonaOperation commented 4 months ago

Awesome, thanks for the update!

Στις Δευ 18 Μαρ 2024 στις 9:46 μ.μ., ο/η cipig @.***> έγραψε:

The PR was merged. Official Desktop will have it when a new release is published in https://github.com/KomodoPlatform/komodo-wallet-desktop/releases Mobile already has it because it gets latest config from github on each start, but it is missing a logo, since that is integrated in the binary, so it will only show a logo when a new release is published there too.

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2004784718, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK2QWT57P32BHYQD2ADYY4777AVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUG44DINZRHA . You are receiving this because you commented.Message ID: @.***>

LeonaOperation commented 4 months ago

Hello team,

If we prepare something like this after our logo update: https://twitter.com/SpaceTokenTech/status/1770137680904442058 Will you make a retweet like you do with a Space token?

Στις Τρί 19 Μαρ 2024 στις 10:22 π.μ., ο/η Leona < @.***> έγραψε:

Awesome, thanks for the update!

Στις Δευ 18 Μαρ 2024 στις 9:46 μ.μ., ο/η cipig @.***> έγραψε:

The PR was merged. Official Desktop will have it when a new release is published in https://github.com/KomodoPlatform/komodo-wallet-desktop/releases Mobile already has it because it gets latest config from github on each start, but it is missing a logo, since that is integrated in the binary, so it will only show a logo when a new release is published there too.

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2004784718, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK2QWT57P32BHYQD2ADYY4777AVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUG44DINZRHA . You are receiving this because you commented.Message ID: @.***>

cipig commented 4 months ago

Just keep in mind that MINU is wallet_only, so it can only be sent and received, not traded. Will have to ask marketing about a retweet, i guess they don't read github comments... but i don't see a reason why they wouldn't retweet.

LeonaOperation commented 4 months ago

Hello,

We will write " wallet integration " , nothing more! Let us know when the logo is up and the desktop app also shows Minu, So we will prepare everything else. Inform your marketing department as you said!

Στις Τετ 20 Μαρ 2024 στις 2:20 μ.μ., ο/η cipig @.***> έγραψε:

Just keep in mind that MINU is wallet_only, so it can only be sent and received, not traded. Will have to ask marketing about a retweet, i guess they don't read github comments... but i don't see a reason why they wouldn't retweet.

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2009439297, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK5M7ISJ42U2UUHZE6LYZF5J3AVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGQZTSMRZG4 . You are receiving this because you commented.Message ID: @.***>

cipig commented 3 months ago

https://twitter.com/KomodoPlatform/status/1779862864108404833

LeonaOperation commented 3 months ago

Hello,

Nice.I will forward in our social team. What about mobile app?

Στις Τρί 16 Απρ 2024 στις 4:40 π.μ., ο/η cipig @.***> έγραψε:

https://twitter.com/KomodoPlatform/status/1779862864108404833

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2058082755, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK5CGWSP46SI3HKFPFLY5R6QPAVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGA4DENZVGU . You are receiving this because you commented.Message ID: @.***>

LeonaOperation commented 3 months ago

Here is our Twitter post: https://twitter.com/minu_coin/status/1780183548223246409

Speak with your team, we want to interact on this! Make a RT or Quote, follow our page if it is possible as well. Thank you!

Στις Τρί 16 Απρ 2024 στις 8:41 π.μ., ο/η Leona < @.***> έγραψε:

Hello,

Nice.I will forward in our social team. What about mobile app?

Στις Τρί 16 Απρ 2024 στις 4:40 π.μ., ο/η cipig @.***> έγραψε:

https://twitter.com/KomodoPlatform/status/1779862864108404833

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2058082755, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK5CGWSP46SI3HKFPFLY5R6QPAVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGA4DENZVGU . You are receiving this because you commented.Message ID: @.***>

LeonaOperation commented 3 months ago

Any news?

Στις Τρί 16 Απρ 2024 στις 1:40 μ.μ., ο/η Leona < @.***> έγραψε:

Here is our Twitter post: https://twitter.com/minu_coin/status/1780183548223246409

Speak with your team, we want to interact on this! Make a RT or Quote, follow our page if it is possible as well. Thank you!

Στις Τρί 16 Απρ 2024 στις 8:41 π.μ., ο/η Leona < @.***> έγραψε:

Hello,

Nice.I will forward in our social team. What about mobile app?

Στις Τρί 16 Απρ 2024 στις 4:40 π.μ., ο/η cipig @.***> έγραψε:

https://twitter.com/KomodoPlatform/status/1779862864108404833

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2058082755, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVK5CGWSP46SI3HKFPFLY5R6QPAVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJYGA4DENZVGU . You are receiving this because you commented.Message ID: @.***>

gcharang commented 3 months ago

@LeonaOperation our team did a retweet of https://twitter.com/minu_coin/status/1780183548223246409

LeonaOperation commented 3 months ago

Hello,

Yes we saw that. Thank you!

Στις Πέμ 18 Απρ 2024 στις 12:06 π.μ., ο/η gcharang @.***> έγραψε:

@LeonaOperation https://github.com/LeonaOperation our team did a retweet of https://twitter.com/minu_coin/status/1780183548223246409

— Reply to this email directly, view it on GitHub https://github.com/KomodoPlatform/coins/issues/1001#issuecomment-2062329981, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCIKVKZA4QBXT6S7ME7DPNDY53P5LAVCNFSM6AAAAABEPTAV7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGMZDSOJYGE . You are receiving this because you were mentioned.Message ID: @.***>

KomodoPlatform / coins

Minu coin listing request #1001