KomodoPlatform / coins

coin parameters and all files needed for GUI support
17 stars 121 forks source link

add DIME #1030

Closed Dhop14 closed 2 months ago

Dhop14 commented 3 months ago

Fails to connect when attempting activation

{"error":"rpc:215] dispatcher_legacy:141] lp_commands_legacy:145] lp_coins:3938] utxo_standard:76] utxo_coin_builder:622] utxo_coin_builder:972] Failed protocol version verifying of at least 1 of Electrums in 5 seconds."}
13 00:11:46, coins::utxo::rpc_clients:2782] INFO Electrum client connected to electrumx.dimecoinnetwork.com:50002
13 00:11:46, coins::utxo::rpc_clients:2808] INFO EOF from electrumx.dimecoinnetwork.com:50002
13 00:11:46, coins::utxo::rpc_clients:2854] INFO electrumx.dimecoinnetwork.com:50002 connection dropped
13 00:11:50, mm2_main::mm2::rpc:289] ERROR RPC error response: rpc:215] dispatcher_legacy:141] lp_commands_legacy:145] lp_coins:3938] utxo_standard:76] utxo_coin_builder:622] utxo_coin_builder:972] Failed protocol version verifying of at least 1 of Electrums in 5 seconds.
13 00:11:50, common::executor::abortable_system::abortable_queue:114] INFO Electrum server.version loop stopped
13 00:12:14, coins::utxo::rpc_clients:2782] INFO Electrum client connected to electrumx2.dimecoinnetwork.com:50002
13 00:12:14, coins::utxo::rpc_clients:2808] INFO EOF from electrumx2.dimecoinnetwork.com:50002
13 00:12:14, coins::utxo::rpc_clients:2854] INFO electrumx2.dimecoinnetwork.com:50002 connection dropped

I was speaking with cipi in discord regarding this issue and it was believed to be a self signed cert issue. However, the cert, at least for electrumx2, has been updated to a LetsEncrypt cert

I get this to return for the version of the electrumx servers, so I am not sure what the hangup is in verification:

myusername@linuxmint:~/komodo-defi-framework-2.0.0-beta/target/debug$ (echo '{ "id": 1, "method": "server.version", "params": ["DIME", ["1.4", "2.0"]] }'; sleep 0.5) | ncat --ssl electrumx.dimecoinnetwork.com 50002
{"jsonrpc":"2.0","result":["ElectrumX 1.16.0","1.4.3"],"id":1}
myusername@linuxmint:~/komodo-defi-framework-2.0.0-beta/target/debug$ (echo '{ "id": 1, "method": "server.version", "params": ["DIME", ["1.4", "2.0"]] }'; sleep 0.5) | ncat --ssl electrumx2.dimecoinnetwork.com 50002
{"jsonrpc": "2.0", "result": ["ElectrumX 1.15.0", "1.4.2"], "id": 1}

And as you can see here:

https://1209k.com/bitcoin-eye/ele.php?chain=dime

SSL connections are open

Test swaps were handled over port 50001

smk762 commented 3 months ago

If they are SSL, please add "protocol": "SSL" for the entries using SSL.

cipig commented 3 months ago

please also move the icon from the icon folder to the icons_original folder... the ones in icons are generated by the GH action script

cipig commented 2 months ago

i fixed everything and moved to a new PR: https://github.com/KomodoPlatform/coins/pull/1049

electrumx2.dimecoinnetwork.com is not in DNS any more, so removed that SSL cert of electrumx.dimecoinnetwork.com is self-signed, which doesn't work, so using TCP for real SSL certs i recommend using the ones from letsencrypt, they are for free