search

KomodoPlatform / coins

coin parameters and all files needed for GUI support
17 stars 123 forks source link

missing icons for some assets listed in the coins_config.json file #519

Closed gcharang closed 2 years ago

gcharang commented 2 years ago

Among the assets listed in https://github.com/KomodoPlatform/coins/blob/master/utils/coins_config.json

the following coins/assets didn't have icons in https://github.com/KomodoPlatform/coins/tree/master/icons

image not found- ADEX BSC: ADEXBSC
image not found- ADEX BSC Testnet: ADEXBSCT
image not found- AtomicSLP: ASLP
image not found- aware token: AWR
image not found- baer chain: BRC
image not found- Bitcoin Cash Testnet: tBCH
image not found- bodhi token: BOT
image not found- cfun token: CFUN
image not found- entertainment cash: ENT
image not found- epc: EPC
image not found- Fake USD: USDF
image not found- fenix.cash: FENIX
image not found- Honk Honk: HONK
image not found- Ilien Swap: ILNSW-PLG20
image not found- PlayCoin: PLY
image not found- sTST: sTST
image not found- winechain: WID
image not found- Zombie: ZOMBIE

maybe the new workflow can keep track of this info too?

cc: @cipig @smk762

smk762 commented 2 years ago

I've done a little brainstorming to include icons in the workflow to automate PRs to include them in desktop is missing once a new coin is added to this repo, but had not considered the inverse. Some of these I'm sure are in desktop repo - though this should now be the central point for all coins data. I'll PR what I can find :+1:

smk762 commented 2 years ago

ADEX is a bit confusing. We have ADEXBSC, ADECBSCT (testnet), ADEX-BEP20 and ADEX-ERC20. I assume they are the same @cipig ? To add more confusion, looks like they rebranded - https://twitter.com/AmbireAdEx/status/1448319436788838404 If confirmed. Will update icon and apply to all variants.

cipig commented 2 years ago

ADEXBSC, ADEXBSCT are just some testcoins... idk if they are in use somewhere... if not, we could remove them ADX-BEP20 and ADX-ERC20 is https://www.coingecko.com/en/coins/ambire-adex

smk762 commented 2 years ago

@artemii235 are ADEXBSC / ADEXBSCT still required for testing any integrations etc? AtomicDEX Test (ADEX) testnet AtomicDEX Test (ADEX) mainnet If so we can add a generic Icon, otherwise can either remove from repo or tag to exclude from coins_config.json