search

KomodoPlatform / coins

coin parameters and all files needed for GUI support
17 stars 123 forks source link

Some livecoinwatch pairs are unsupported for charts #698

Closed smk762 closed 1 year ago

smk762 commented 1 year ago

It seems for some minor coins which are supported by livecoinwatch may not be supported as a pair. I can't think of a method to filter these out without using a pair exclusion list.

https://user-images.githubusercontent.com/35845239/230338626-9a359d94-dd1d-4208-a2f7-38fe9302f09b.mp4

Originally posted by @smk762 in https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/2239#issuecomment-1498778473

cipig commented 1 year ago

the reason is that the coin, in this case ECA, has no price, although it's listed... it's because nobody trades those coins https://www.livecoinwatch.com/price/Electra-ECA does not have a price, nor a market

smk762 commented 1 year ago

Do you think we should remove the chart ID in these cases?

endrilickollari commented 1 year ago

I think if thats the case, that it does not have the price, I can make a list with them. I think in the response of those coins properties like price or market are null.

cipig commented 1 year ago

i would keep them, the price may come back... for ECA pairs need to be added, but i guess some other coins will have the same problem i also don't know how livecoinwatch is dealing with pairs and if they don't show up because there were no trades or because they are not listed or whatever... will need to find out how all this works on livecoinwatch FJC will have the same problem... and for FJC there are sometimes trades on ADEX we just need to add the pairs ADEX is already listed: https://www.livecoinwatch.com/exchange/atomicdex i asked them in their discord why there are only 2 pairs... i assume they are using the wrong endpoint, markets.atomicdex.io... told them to use https://stats-api.atomicdex.io/api/v1/summary instead... we will see anyway, some of those coins may come back, so i would keep them listed for now

smk762 commented 1 year ago

We dont use it as a price source yet, but would be good to have that option in future. @cipig how well do their prices compare to other sources?

smk762 commented 1 year ago

i asked them in their discord why there are only 2 pairs... i assume they are using the wrong endpoint, markets.atomicdex.io... told them to use https://stats-api.atomicdex.io/api/v1/summary instead... we will see anyway, some of those coins may come back, so i would keep them listed for now

Feel free to give them my contact details if they need any work done on our APIs for compatibility.

endrilickollari commented 1 year ago

In my opinion the problem might be the cases where coins (test coins) like ZOMBIE can have a misleading chart, because they don't query only with the code, in this case ZOMBIE, they search if the coin contains the code, and in ZOMBIE case it returns something like Zombie.Finance. But the question is are there other coins that can mislead us?!

cipig commented 1 year ago

how well do their prices compare to other sources?

good question i already discovered a bigger difference on ZEC... compare https://www.livecoinwatch.com/price/Zcash-ZEC with https://www.coingecko.com/en/coins/zcash ... the problem comes from YoBit, as so often... this CEX is crap as hell and data is likely fake... i also told them that in the discord... maybe it's also a bug, it shows a volume of 32M (Binance has 3M for ZEC) and a liquidity of 100 USD... so either bug or just fake... i assume fake...

smk762 commented 1 year ago

In my opinion the problem might be the cases where coins (test coins) like ZOMBIE can have a misleading chart, because they don't query only with the code, in this case ZOMBIE, they search if the coin contains the code, and in ZOMBIE case it returns something like Zombie.Finance. But the question is are there other coins that can mislead us?!

For zombie, its filtered out because its tagged as a testcoin. There are some other cases like VAL https://github.com/KomodoPlatform/coins/blob/master/utils/coins_config.json#L35237 where duplicated tickers get a _ (or __) prefix. Cipi has identified and updated these where found, but we should remain vigilant to find any others.

cipig commented 1 year ago

In my opinion the problem might be the cases where coins (test coins) like ZOMBIE can have a misleading chart

ZOMBIE was removed from https://github.com/KomodoPlatform/coins/blob/master/api_ids/livecoinwatch_ids.json, it shouldn't show any chart.

endrilickollari commented 1 year ago

I am aware for ZOMBIE. But can there be case like ZOMBIE?

endrilickollari commented 1 year ago

Those coins did not had have data at https://www.livecoinwatch.com/

{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  AGEUR
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  ASLP
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  AVAXT
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  BANANO
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  BITN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  BNBT
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  BSTY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  CADC
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  CASE
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  EILN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  FJCB
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  FTMT
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  GRMS
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  IL8P
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  ILN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  ILNF
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  ILNSW
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  IOTA
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JAUD
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JBRL
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JCAD
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JCHF
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JCNY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JGBP
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JGOLD
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JJPY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JKRW
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JMXN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JNZD
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JPHP
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JPLN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JSEK
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JSGD
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JTRY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JUMBLR
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  JUSD
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  KIP0001
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  LSTR
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  MATICTEST
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  MGW
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  MORTY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  MSHARK
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  NZDS
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  PANGEA
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  PAX
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  PRUX
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  PSF
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  QIAIR
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  QRC20
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  REVS
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  RUNES
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  SBCH
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  SIBM
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  SOULJA
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  SOUR
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  STFIRO
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  SUPERNET
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  USBL
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  VOTE2023
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  VPRM
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  WCN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  WWCN
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  XVC
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  sTST
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  tBCH
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  tBLK
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  tBTC
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ==== SEARCH COIN ====>  tQTUM
endrilickollari commented 1 year ago

the reason is that the coin, in this case ECA, has no price, although it's listed... it's because nobody trades those coins https://www.livecoinwatch.com/price/Electra-ECA does not have a price, nor a market

About this @cipig I will filter with those properties: 

"rate": 28146.024532356867,
  "volume": 10531977018,
  "cap": 544313857479,
  "liquidity": 1088716890,

Thats BTC, but as I observed for other coins there were cases where those props were null.

BTC: 

{
  "name": "Bitcoin",
  "symbol": "₿",
  "rank": 1,
  "age": 5206,
  "color": "#fa9e32",
  "png32": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/32/btc.png",
  "png64": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/64/btc.png",
  "webp32": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/32/btc.webp",
  "webp64": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/64/btc.webp",
  "exchanges": 196,
  "markets": 3799,
  "pairs": 1103,
  "categories": [],
  "allTimeHighUSD": 68780.77475755227,
  "circulatingSupply": 19338925,
  "totalSupply": 19338925,
  "maxSupply": 21000000,
  "links": {
    "website": "https://bitcoin.org/",
    "whitepaper": "https://bitcoin.org/bitcoin.pdf",
    "twitter": null,
    "reddit": "https://reddit.com/r/bitcoin",
    "telegram": null,
    "discord": null,
    "medium": null,
    "instagram": null
  },
  "rate": 28146.024532356867,
  "volume": 10531977018,
  "cap": 544313857479,
  "liquidity": 1088716890,
  "delta": {
    "hour": 0.9995,
    "day": 1.0018,
    "week": 1.0125,
    "month": 1.2533,
    "quarter": 1.6715,
    "year": 0.6408
  }
}

ECA: 

{
  "name": "Electra",
  "rank": 17228,
  "age": 2103,
  "color": "#8e0cb0",
  "png32": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/32/eca.png",
  "png64": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/64/eca.png",
  "webp32": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/32/eca.webp",
  "webp64": "https://lcw.nyc3.cdn.digitaloceanspaces.com/production/currencies/64/eca.webp",
  "exchanges": 0,
  "markets": 0,
  "pairs": 0,
  "categories": [],
  "allTimeHighUSD": 0.00650232,
  "circulatingSupply": 28356802598,
  "totalSupply": 28356802598,
  "maxSupply": 30000000000,
  "links": {
    "website": "https://electraproject.org/",
    "whitepaper": null,
    "twitter": "https://twitter.com/ElectracoinECA",
    "reddit": "https://reddit.com/r/Electra_Currency",
    "telegram": "https://t.me/electracoineca",
    "discord": null,
    "medium": null,
    "instagram": null
  },
  "rate": null,
  "volume": null,
  "cap": null,
  "liquidity": null,
  "delta": {
    "hour": null,
    "day": null,
    "week": null,
    "month": null,
    "quarter": null,
    "year": null
  }
}
cipig commented 1 year ago

Those coins did not had have data at https://www.livecoinwatch.com/

some of them have other ids, some are not listed... i already fixed many of them, and there is this open PR with more: https://github.com/KomodoPlatform/coins/pull/692

endrilickollari commented 1 year ago

Those coins did not had have data at https://www.livecoinwatch.com/

some of them have other ids, some are not listed... i already fixed many of them, and there is this open PR with more: KomodoPlatform/coins#692

After getting data from this PR, those were coins with no data: 

{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ===> Search coin ===> BSTY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ===> Search coin ===> XVC
endrilickollari commented 1 year ago

Coins with 0 markets or rate = null

['ABY', 'AUR', 'AXE', '_BTE', 'CDN', 'DGC', 'DIMI', 'DOGEDASH', 'DP', 'ECA', 'EFL', 'FJC', 'HLC', 'HOT', 'HPY', 'IMX', 'JOY', 'LOOP', 'LYNX', 'MINDS', 'NVC', 'OC', 'QC', '_SWAP', '_TFT', 'THC', 'TKL', 'TRYB', 'TTT', 'UIS', 'UNO', 'XPM', 'XRG', 'ZER', 'ZET']
Total coins with 0 markets or rate = null are: 35
cipig commented 1 year ago

After getting data from this PR, those were coins with no data:

{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ===> Search coin ===> BSTY
{"error":{"code":400,"status":"Bad request","description":"Unknown coin code."}} ===> Search coin ===> XVC

i removed those too: https://github.com/KomodoPlatform/coins/pull/692/commits/bca9594b56fdbfdb40cdaadf5f7c9b612a95f802

cipig commented 1 year ago

found out that we can get charts for some stablecoins by linking them to the respective fiat currency image

but it works only one way, this doesn't work: image

but i guess it's still worth adding what do you think?

endrilickollari commented 1 year ago

Here are detailed view, with what we search and what we get for coins with 0 markets and null rates:

coins.txt

If there is any properties that we need, tell me to re-upload a new one.

cipig commented 1 year ago

Here are detailed view, with what we search and what we get for coins with 0 markets and null rates:

Seeing that some of the ids from the list are wrong, like for HOT and IMX. Will need to fix those too, they are pointing to the wrong coins.

endrilickollari commented 1 year ago

Here are detailed view, with what we search and what we get for coins with 0 markets and null rates:

Seeing that some of the ids from the list are wrong, like for HOT and IMX. Will need to fix those too, they are pointing to the wrong coins.

I am working on a script where we take all the coins. Will upload for a few minutes. maybe we can relate to all coins.

endrilickollari commented 1 year ago

Here are detailed view, with what we search and what we get for coins with 0 markets and null rates:

Seeing that some of the ids from the list are wrong, like for HOT and IMX. Will need to fix those too, they are pointing to the wrong coins.

I am working on a script where we take all the coins. Will upload for a few minutes. maybe we can relate to all coins.

Here is the new file with all the coins: all_coins.txt

cipig commented 1 year ago

Here is the new file with all the coins:

Thanks. I will look at all the coins there and do more id-fixes. I can see it by the name of all those coins, which is a bit weird :-)

endrilickollari commented 1 year ago

Here is the new file with all the coins:

Thanks. I will look at all the coins there and do more id-fixes. I can see it by the name of all those coins, which is a bit weird :-)

I was wondering if we can "automate" the filtering by involving this property here:

image

found at: https://raw.githubusercontent.com/KomodoPlatform/coins/master/utils/coins_config.json

cipig commented 1 year ago

I was wondering if we can "automate" the filtering by involving this property here:

Only if we would use the exact same coin name all the time as them. I don't think it's realistic. But i looked at the entire file you sent and found only one last id to fix, so this PR https://github.com/KomodoPlatform/coins/pull/692 is now final. I will only add some stablecoin -> fiat links, especially for the stablecoins from Jarvis.