KomodoPlatform / coins

coin parameters and all files needed for GUI support
17 stars 123 forks source link

Scan wss, add wss for FIRO #960

Closed smk762 closed 7 months ago

smk762 commented 7 months ago

Building on https://github.com/KomodoPlatform/coins/pull/959/files (changed protocol to WSS)

Updated config gen script to properly scan wss and add responding servers to coins_config.json

To test:

kivqa commented 7 months ago

@smk762 generated coin_config does not contain "url" field for FIRO:

image

Expected:

image

Without "url" field I catch error in console for web wallet:

image
cipig commented 7 months ago

Without "url" field I catch error in console for web wallet:

why does web wallet look at "url" field? it doesn't use it anyway, since url contains only TCP or SSL port and web can't use that, web can only use what's in "ws_url" maybe we should change the entire schema and make it "url" for each 3 protocols, removing the param "ws_url"... so url with protocol TCP, SSL or WSS... atm

cipig commented 7 months ago

in Desktop i can still enable FIRO

smk762 commented 7 months ago

@smk762 generated coin_config does not contain "url" field for FIRO: image Expected: image

Without "url" field I catch error in console for web wallet: image

if url value is the same as the ws_url value, errors may be encountered as tcp connections may be attempted to the same url/port. Generally the url field would be on a different port (the one for SSL), but seems FIRO only has TCP servers listed.

e.g.


            {
                "url": "elec-seeder-one.artbytecoin.org:50012",
                "protocol": "SSL",
                "disable_cert_verification": true,
                "ws_url": "elec-seeder-one.artbytecoin.org:50013"
            },
            {
                "url": "elec-seeder-two.artbytecoin.org:50012",
                "protocol": "SSL",
                "ws_url": "elec-seeder-two.artbytecoin.org:50013"
            }
smk762 commented 7 months ago

ws_url vs url issue resolved in config gen script. All ws_url entries have been moved into their own block, using url key, and are present in coins_config.json and coins_config_wss.json