updates vrsc to v1.1.1-1 (upd) - Githubissues

KomodoPlatform / dPoW

Komodo delayed Proof of Work software

36 stars 73 forks source link

updates vrsc to v1.1.1-1 (upd) #520

Closed gcharang closed 10 months ago

gcharang commented 10 months ago

Issue raised: https://github.com/KomodoPlatform/dPoW/issues/519 PR to the docker repo: https://github.com/smk762/notary_docker_3p/pull/45 diff: https://github.com/VerusCoin/VerusCoin/compare/2d327210fddc245c693d00c9a025bd81f5f079eb...2eb2238dbbbda7aba610fa439d69306e8f62b9ae

Updated info for v1.1.1-1:

issue: https://github.com/KomodoPlatform/dPoW/issues/521
PR to the docker repo: https://github.com/smk762/notary_docker_3p/pull/48
diff from v1.1.1: https://github.com/VerusCoin/VerusCoin/compare/2eb2238dbbbda7aba610fa439d69306e8f62b9ae...25f82df12aee24c64681ca69ddd21ae19528fe25
diff from last dPoW update: https://github.com/VerusCoin/VerusCoin/compare/2d327210fddc245c693d00c9a025bd81f5f079eb...25f82df12aee24c64681ca69ddd21ae19528fe25

TheComputerGenie commented 10 months ago

https://discord.com/channels/444621794964537354/449633429198340106/1147345315389767751

Alrighttt commented 10 months ago

LGTM, no obvious memory errors or malicious inclusions.

Just one question, why did they change the zlib download path to github? The newer version is also available at https://www.zlib.net/

CHMEX commented 10 months ago

Zlib tends to immediatly remove old versions which causes the build to break. If on your GH you can controll and update yourself