search

KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
104 stars 94 forks source link

remove/improve banning #1091

Closed cipig closed 3 months ago

cipig commented 3 years ago

The current banning system leads to many orders that are not fillable. For me 80-90% of the orders in MCL/KMD orderbook are not fillable. Problem is that some users tend to keep their ADEX Desktop running and the banning is only removed when they restart. Once you had a failed swap with a certain pubkey (eg because of waiting too long for tx confirmation/notarization), you will not be able to swap with that pubkey any more till the user restarts his ADEX Desktop, which can take weeks/months. How about removing bans automatically after some time (1 to couple hours)?

artemii235 commented 3 years ago

TakerPaymentWaitConfirmFailed and MakerPaymentWaitConfirmFailed are not events that lead to the pubkey ban. Could it be another reason?

But in general, I agree that banning in its current form is quite suboptimal. Maybe it's worth removing it completely and wait until we implement a better reputation system. I will consider the options and get back to this issue.

cipig commented 3 months ago

removing all bans after a certain period of time would be the easiest, i guess, so closing as duplicate of https://github.com/KomodoPlatform/komodo-defi-framework/issues/1985