KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
107 stars 94 forks source link

Support NEX UTXO transaction format. #1476

Open artemii235 opened 2 years ago

artemii235 commented 2 years ago

https://github.com/KomodoPlatform/coins/pull/483#issuecomment-1247266295

cc @smk762 @modenero

modenero commented 2 years ago

@artemii235 i've dedicated this week to working on this integration i'm prepared to help in any way I can..

laruh commented 2 years ago

Hi @modenero Could you please send some NEX to nexa:qr8mh99l4nnjpfyhsmj8m65ksmgrlqygwgjh37ywez address? It's mine. I will be trying to send it back to nexa:qqwnm809af5muc4cjua74d7ze3lwqt0utvmx7u8kyg for testing.

modenero commented 2 years ago

hi @laruh

so happy for your support :smile:

i've just sent 1,000.000.00 NEX to your address

https://explorer.nexa.org/tx/7f194970c7be9566d0a2df357cfa74fee95c292396f1c88ee10d61e2ae2542d1

and please let me know how I can help in any way

laruh commented 2 years ago

hi @laruh

so happy for your support smile

i've just sent 1,000.000.00 NEX to your address

https://explorer.nexa.org/tx/7f194970c7be9566d0a2df357cfa74fee95c292396f1c88ee10d61e2ae2542d1

and please let me know how I can help in any way

Very well, got it, thanks! {"coin":"NEX","balance":"1000000","unspendable_balance":"0","address":"nexa:qr8mh99l4nnjpfyhsmj8m65ksmgrlqygwgjh37ywez"} Of course! If there are questions, I will ping you in this conversation.

artemii235 commented 2 years ago

@modenero Unfortunately, due to significant differences in NEX and BTC (and most of the forks) transaction format, we are not able to support it now. It will trigger too many changes in our UTXO coins handling code. Could you please provide an address to which we should send your coins back?

laruh commented 2 years ago

@modenero Hi, sorry, can I just send you btc or usdt for your coins? It will be much easier and faster since withdraw method doesn't work properly. So provide me please the address and amount of preferable coin. Also, is there a source where I can see the value of the NEX?

modenero commented 2 years ago

@artemii235 @laruh

ahhhh... it's unfortunate that Nexa won't joining the Komodo family at this time. but i really, REALLY appreciate your time and efforts in trying to make it happen.

would you be kind enough to point me to the location of the "coins handling code" so that I may share this as a "challenge" for members of the Nexa developer community?


and there is certainly no need to return any NEX (or equivalent). i'm hopefully that what you're holding will still be put to good use some time in the near future 😉

artemii235 commented 2 years ago

@modenero

would you be kind enough to point me to the location of the "coins handling code" so that I may share this as a "challenge" for members of the Nexa developer community?

There are a few important locations: https://github.com/KomodoPlatform/atomicDEX-API/blob/dev/mm2src/mm2_bitcoin/chain/src/transaction.rs - Transaction struct, its de/serialization, etc. https://github.com/KomodoPlatform/atomicDEX-API/blob/dev/mm2src/mm2_bitcoin/script/src/sign.rs - Sighash generation. https://github.com/KomodoPlatform/atomicDEX-API/tree/dev/mm2src/coins/utxo_signer - UTXO tx signer https://github.com/KomodoPlatform/atomicDEX-API/blob/dev/mm2src/coins/utxo.rs and https://github.com/KomodoPlatform/atomicDEX-API/tree/dev/mm2src/coins/utxo - AtomicDEX specific UTXO coins handling code.

If you need assistance or more details about the code, please let us know.

and there is certainly no need to return any NEX (or equivalent). i'm hopefully that what you're holding will still be put to good use some time in the near future 😉

Thanks a lot! 🙂

modenero commented 2 years ago

@artemii235 thank you so much for all you and your team have done to help our community join yours. :pray: Nexa has a wealth of talented individuals that I'm hoping will be able to pickup from the point at which you've brought us and get us over the finish line. I'll take a lil time to summarize the links you've shared and then brief the Nexa community on what lies ahead.

i look forward to "trustlessly" trading Nexa on AtomicDEX in the upcoming year! :partying_face:

cheers!