Open ca333 opened 1 year ago
Checklist:
mm2src/coins/coin_balance.rs
and related HD wallet balance implementations to hd_wallet
mod.We've discussed several enhancements internally that can benefit the GUI team in their implementation of the HD wallet feature. Below are the proposed enhancements:
Hide Addresses with Zero Balance:
Enhanced Account Management:
"transfers": 0
. For used addresses, it displays something like:
{
"transfers": 5,
"balance": "7282",
"sent": "14746",
"received": "22028"
}
Something similar to this should be added to the responses.
Hide Certain Addresses:
Public Key Exposure:
Account Number and Address Scanning:
We believe Ethereum should use the SEP-0005
scheme for everything, because it is account-based, rather than UTXO-based.
Unfortunately, many Ethereum tools (MEW, Metamask) do not use such a scheme
and set account = 0 and then iterate the address index. For compatibility,
we allow this scheme as well.
Concurrent Address Scanning:
The HD-Wallet implementation is flawed and does not align with the official BIP32/44 standards as we seem only incrementing / deriving on the address index level with a static (potentially config-derived?) account id.
https://github.com/KomodoPlatform/atomicDEX-API/blob/371595d6c0d322e677669544aa37ec6304140fe8/mm2src/crypto/src/standard_hd_path.rs#L18
expectation: