KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
97 stars 88 forks source link

feat(trading-proto-upgrade): fees fixes among other things #2109

Open mariocynicys opened 1 month ago

mariocynicys commented 1 month ago

The main feat here is taker payment spend fee negotiation (I guess we will refactor namings in the swaps v2 code and rename this to taker payment fee/funding spend fee):

The negotiation goes as follows:

Proto v2 issue pool:

Fixmes & discuss comments are intended to be covered in the PR.

shamardy commented 1 month ago

@mariocynicys please add label for if this is under review or in progress.

laruh commented 1 month ago

@mariocynicys please merge dev to feature branch as it contains build fixes https://github.com/KomodoPlatform/komodo-defi-framework/actions/runs/8965111556/job/24617995991?pr=2109#step:8:574

error[E0463]: can't find crate for `core`
  |
  = note: the `x86_64-apple-darwin` target may not be installed
  = help: consider downloading the target with `rustup target add x86_64-apple-darwin`
  = help: consider building the standard library from source with `cargo build -Zbuild-std`
laruh commented 4 weeks ago

ps @mariocynicys this pr started to have conflicts

laruh commented 1 week ago

ps @mariocynicys lint check fails