search

KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
103 stars 94 forks source link

chore(toolchain): upgrade to 1.72 nightly #2149

Closed onur-ozkan closed 3 months ago

onur-ozkan commented 3 months ago

This should greatly help for people working on solana-sdk upgrade and the stable toolchain migration work.

Should be easy to review commit-by-commit.

laruh commented 3 months ago

Thanks for the toolchain upgrade. Now wasm-bindgen-cli does not conflict with the toolchain version on macOS.

Note: wasm-pack downloads wasm-bindgen-cli automatically when you run the build command, as wasm-pack itself does not have some binaries for macOS.

Could you please write for OSX users (Apple Silicon): instead of for OSX users (M1):, so we don't need to repeat all new M chip versions

https://github.com/KomodoPlatform/komodo-defi-framework/blob/update-nightly-toolchain/docs/WASM_BUILD.md?plain=1#L28

https://github.com/KomodoPlatform/komodo-defi-framework/blob/update-nightly-toolchain/docs/DEV_ENVIRONMENT.md?plain=1#L64

onur-ozkan commented 3 months ago

Thanks for the toolchain upgrade. Now wasm-bindgen-cli does not conflict with the toolchain version on macOS.

Note: wasm-pack downloads wasm-bindgen-cli automatically when you run the build command, as wasm-pack itself does not have some binaries for macOS.

Could you please write for OSX users (Apple Silicon): instead of for OSX users (M1):, so we don't need to repeat all new M chip versions

https://github.com/KomodoPlatform/komodo-defi-framework/blob/update-nightly-toolchain/docs/WASM_BUILD.md?plain=1#L28

https://github.com/KomodoPlatform/komodo-defi-framework/blob/update-nightly-toolchain/docs/DEV_ENVIRONMENT.md?plain=1#L64

Done https://github.com/KomodoPlatform/komodo-defi-framework/pull/2149/commits/058afa00be4ded6b01f914f7e2fed5cba784aecc