KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
106 stars 94 forks source link

feat(cosmos): support IBC types in tx history implementation #2245

Closed onur-ozkan closed 2 weeks ago

onur-ozkan commented 1 month ago

Cosmos transaction history implementation was incorrectly parsing addresses (using the relayer address instead of the cross-chain address) from IBC transactions. This PR fixes the address parsing logic and adds test coverage for it.

This should not be merged before https://github.com/KomodoPlatform/komodo-defi-framework/pull/2246.

To Test: Already tested https://github.com/KomodoPlatform/komodo-defi-framework/pull/2245#issuecomment-2459008195

shamardy commented 3 weeks ago

@onur-ozkan has this been tested by someone already? if not, please add To Test here https://github.com/KomodoPlatform/komodo-defi-framework/pull/2245#issue-2588357205 and QA label and merge it.

onur-ozkan commented 2 weeks ago

@onur-ozkan has this been tested by someone already? if not, please add To Test here #2245 (comment) and QA label and merge it.

It was tested by @naezith I believe.

naezith commented 2 weeks ago

https://www.mintscan.io/cosmos/tx/B8D51F5F9D0702E0EFF87824F17B93DEBF418598A5888E71A848AEFC9286EAA6 https://irishub.iobscan.io/#/txs/D5A7B0AB8A5CE82CDC38FB7FCE6A8768F0B83F4DD19D7C20328CDCDCED5219FD

image

image