search

KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
104 stars 94 forks source link

make `ibc_source_channel` required for IBC transfers #2271

Open onur-ozkan opened 23 hours ago

onur-ozkan commented 23 hours ago

For IBC transfers, if ibc_source_channel is not provided, we currently try to detect it automatically from https://github.com/cosmos/chain-registry. But this approach is risky and unreliable as the channels are often outdated, which could lead to a loss of funds (the fee part only). To improve safety and reliability we should remove this auto-detection logic and require users to specify ibc_source_channel manually and make them responsible for its correctness. This approach will allow users to rely on more reliable IBC channels by simply picking the most popular ones from sources like https://ibc.iobscan.io/channels.

onur-ozkan commented 23 hours ago

These

https://github.com/KomodoPlatform/komodo-defi-framework/blob/dfca6b753adad0535e2ad8728c0fa36b0a871b6c/mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs#L209-L210

2 RPCs should be removed as well.