search

KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
104 stars 94 forks source link

[Discussion] Active/Non-active coins distinction. #665

Closed dth88 closed 3 years ago

dth88 commented 4 years ago

Currently, both our products(adex-mob and pro) lack this functionality https://github.com/KomodoPlatform/atomicDEX-Pro/issues/210, would that be a good idea to suggest a fix on API side? for e.g. it would first return batches with coins that have balances or tx_history and only when there are none of those 'active' coins it starts sending 'non-active' ones. Or would it be a bad idea because API would lose performance on that sorting?

it might also ease the job on other developers who are willing to create their own apps. Just a thought, let's discuss!

artemii235 commented 4 years ago

I think it is good idea definitely. Such balance/history scan may be time and traffic consuming so it shouldn't be default behavior IMHO. We can give users choice whether to scan for all available coins when seed is imported and wait for it or just pick some coins manually later and get immediate application activation.

tonymorony commented 3 years ago

closing in favor of fresher one https://github.com/KomodoPlatform/atomicDEX-API/issues/1016 :)