search

KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
104 stars 94 forks source link

Library release for Windows and Linux #696

Closed DaemonSnake closed 4 years ago

DaemonSnake commented 4 years ago

Hi, Currently the library version of mm2 is only available for Darwin in the release assets. Would it be possible to have the Windows and Linux version too? Thanks

tonymorony commented 4 years ago

Hi @DaemonSnake !

On releases page you can find atomicdex-api binaries for OSX/Linux/Windows. For example:

image

DaemonSnake commented 4 years ago

Hi @tonymorony,

I am aware of the presence of the pre build binaries. What I was referring to is that Darwin is the only target for which the library version of mm2 is packaged.

binaries

As you can see none of Linux/Windows packages contains a library version of mm2

Whist both Release and Debug packages for Darwin contains the mm2 binary and the library version: Screenshot_20200707_112605

As we can see in the azure pipeline yaml file, only the Darwin lib is packaged.

https://github.com/KomodoPlatform/atomicDEX-API/blob/8a284f022b299d63e4cb858444009a760333e998/azure-pipelines-release-stage-job.yml#L76 https://github.com/KomodoPlatform/atomicDEX-API/blob/8a284f022b299d63e4cb858444009a760333e998/azure-pipelines-release-stage-job.yml#L117

The name of the lib for linux being 'libmm2.a' for linux it is not packaged.

artemii235 commented 4 years ago

The corresponding PR was merged, closing.