KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
104 stars 94 forks source link

Request balance and utxos for both P2KH and P2PKH script hashes from Electrum. #720

Closed artemii235 closed 3 months ago

artemii235 commented 4 years ago

As of now MM2 uses only P2PKH script hash so it might get incorrect balance and utxos from Electrum if the address has P2PK utxos.

https://discordapp.com/channels/412898016371015680/449950331577565194/756147006237573150

https://github.com/kyuupichan/electrumx/issues/818#issuecomment-633497973

artemii235 commented 3 years ago

We should also consider implementing the same for Native mode.

michelvankessel commented 3 years ago

I can confirm this happens with Coinstakes too. (Blackcoin, PoSv3)

cipig commented 2 years ago

would solving this issue also make it possible to see and spend the timelocked transactions from TKL? the vout of such a tx in question looks like this

    {
      "value": 62854.37046316,
      "valueSat": 6285437046316,
      "n": 1,
      "scriptPubKey": {
        "asm": "1655251200 OP_NOP2 OP_DROP OP_DUP OP_HASH160 4d2a1a4748205d088a382f2023cad8ea6403f6cc OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "040021a962b17576a9144d2a1a4748205d088a382f2023cad8ea6403f6cc88ac",
        "type": "pubkeyhash"
      }
    }

if so, then it would be nice if he could prioritize this, some TKL rewards were unlocked today and can not be seen or spent on ADEX Desktop with electrums

smk762 commented 1 year ago

@shamardy @ozkanonur can we please implement this? I just encountered the same discrepancy between explorer balance and API balance related to this.

shamardy commented 1 year ago

@shamardy @ozkanonur can we please implement this?

Sure, I can take a look at it next week.

shamardy commented 3 months ago

Fixed here https://github.com/KomodoPlatform/komodo-defi-framework/pull/2053