KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
105 stars 94 forks source link

Hate to say this, but emojis should go... #777

Open dth88 opened 3 years ago

dth88 commented 3 years ago

Here's an error which points to the emoji:

E/art     (10169): JNI DETECTED ERROR IN APPLICATION: input is not valid Modified UTF-8: illegal start byte 0xf0
E/art     (10169):     string: '😅 2020-12-18 02:17:54 +0700 [myipaddr] We couldn't bind on the external IP 94.230.167.228, so NAT is likely to be present. We'll be okay though.'
E/art     (10169):     in call to NewStringUTF
E/art     (10169): "Thread-536" prio=5 tid=31 Runnable
E/art     (10169):   | group="main" sCount=0 dsCount=0 obj=0x32e62580 self=0x7f86fd0000
E/art     (10169):   | sysTid=11066 nice=0 cgrp=default sched=0/0 handle=0x7fa201c000
E/art     (10169):   | state=R schedstat=( 51172853 21892531 121 ) utm=4 stm=1 core=5 HZ=100
E/art     (10169):   | stack=0x7f40282000-0x7f40284000 stackSize=2044KB
E/art     (10169):   | held mutexes= "mutator lock"(shared held)
E/art     (10169):   native: #00 pc 000046bc  /system/lib64/libbacktrace_libc++.so (_ZN9Backtrace6UnwindEmP8ucontext+28)
E/art     (10169):   native: #01 pc 0000001c  ???
E/art     (10169):   (no managed stack frames)
F/libc    (10169): Fatal signal 6 (SIGABRT), code -6 in tid 11066 (Thread-536)
Lost connection to device.

Essentially blocks me from launching adex-mob in debug mode on Android, thus I cant regression test, thus I cant ci/cd, etc. And in many cases blocks users with god-forsaken phones like mine (Android 5.1 and less?) from using mobile GUI. I have to either buy a newer phone or ask you to remove emojis.

@artemii235 I understand that emojis can mean a lot to someone, therefore just humbly asking to consider such proposition, and would be waiting in respectful silence for your decision. 😅

gcharang commented 3 years ago

If it isn't too much work, a flag or config option to turn emojis to ascii versions can provide the best of both

artemii235 commented 3 years ago

I think that removing the emojis is the simplest way and I don't mind it personally. However, someone might have arguments against the removal so let's wait a bit for more comments :slightly_smiling_face:

dth88 commented 3 years ago

<<<(((;....;)))>>> I'm sure we will be able to find a substitute for any emoji with ascii :D

sergeyboyko0791 commented 3 years ago

As far as I know, mobile app doesn't depend on log parsing, so we can get rid of tagged logs including emoji. What about the desktop app?

ca333 commented 3 years ago

liked the emojis a lot - maybe we can just replace with ascii equivalents

BloodyNora commented 3 years ago

remember there may be people (like me, coincidentally) whose terminals cannot for whatever reason display 8 or 16 byte long multibyte characters. i agree with ca333 on using ascii emoji representations.