ETH/ERC20 withdraw always return hardcoded ETH in fee_details. - Githubissues

KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository

https://komodoplatform.com/en/docs/komodo-defi-framework/

104 stars 95 forks source link

ETH/ERC20 withdraw always return hardcoded ETH in fee_details. #860

Closed artemii235 closed 3 years ago

artemii235 commented 3 years ago

This can actually be a part of https://github.com/KomodoPlatform/atomicDEX-API/issues/801. Checklist:

[ ] Get BNB on Binance smart chain testnet.
[ ] Deploy a BEP20(ERC20) token to BSC testnet.
[ ] Add the Binance smart chain BNB (BSCBNBT - T stands for testnet) and deployed BEP20 to coins config.
[ ] Fix the withdraw RPC for BSCBNBT and BEP20 so it displays BSCBNBT coin in fee_details.

Withdraw docs: https://developers.atomicdex.io/basic-docs/atomicdex/atomicdex-api.html#withdraw ETH example in coins file: https://github.com/KomodoPlatform/coins/blob/master/coins#L622

artemii235 commented 3 years ago

Hardcode is fixed, BNB/BEP20 integration is tracked in another issue, closing.