KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
103 stars 94 forks source link

Etomic trades don't execute successfully #90

Closed brrrrrr closed 5 years ago

brrrrrr commented 6 years ago

Describe the bug A clear and concise description of what the bug is.

We think we are all set. Komodo native, Etomic active. Eth funded (both sides) HYD funded. Etomic funded (plenty utxos). KMD funded. sufficient utxos and Zcredits. Smart address: RPgJffb45kmNjpfBjkQgsfwsCaXk1q5mta

Autotrade script:

source userpass
curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"autoprice\",\"base\":\"HYD\",\"rel\":\"KMD\",\"fixed\":0.5,\"margin\":0.00001}"`

We'll start Komodod, Etomic, Marketmaker, Enable, Auto trade. HYD enters the order book.

Alice (ETH funded, KMD funded, plenty utxos) puts in order. Alice runs 1.0.7.rc GUI

Bob's console:

1920 uuid.47f55a1bc820de6af4cb7307c685e13b      request   HYD/KMD     1.00039999 ->   0.50060000 ( 0.50040485) | RT.2 3196 n0
1921 uuid.47f55a1bc820de6af4cb7307c685e13b     reserved   HYD/KMD     1.00079863 ->   0.50060000 ( 0.50020552) | RT.2 3196 n0
1922 uuid.47f55a1bc820de6af4cb7307c685e13b      connect   HYD/KMD     1.00079863 ->   0.50060000 ( 0.50020552) | RT.2 3196 n0

And a bit later.

1924 uuid.47f55a1bc820de6af4cb7307c685e13b    connected   HYD/KMD     1.00079863 ->   0.50060000 ( 0.50020552) | RT.2 3196 n0
AUTOPRICE numautorefs.1

Then it just stops.

Meanwhile in Alice' BarterDEX GUI the trade shows as:

realtime
Quote ID: 1299518380
Request ID: 2625546241

As soon as the swap enters 'trade status' in Alice' GUI it reports 'swap never started' When you try to kickstart it says 'finished. file removed'

Please answer following questions and attach requested info - it'll help to solve issue faster

respons:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 53781    0 53606  100   175   127k    427 --:--:-- --:--:-- --:--:--  128k
[{"coin":"KMD","installed":true,"height":903375,"balance":4.98598968,"KMDvalue":4.98598968,"status":"active","smartaddress":"RPgJffb45kmNjpfBjkQgsfwsCaXk1q5mta","rpc":"127.0.0.1:7771","pubtype":60,"p2shtype":85,"wiftype":188,"txfee":1000,"zcredits":0,"zdebits":{"swaps":[],"pendingswaps":0}}]
[{"coin":"ETOMIC","installed":true,"height":19711,"balance":1114.31191333,"KMDvalue":0,"status":"active","smartaddress":"RPgJffb45kmNjpfBjkQgsfwsCaXk1q5mta","rpc":"127.0.0.1:10271","pubtype":60,"p2shtype":85,"wiftype":188,"txfee":1000}]
[{"coin":"ETH","installed":false,"height":-1,"balance":0.02643242,"status":"active","smartaddress":"0x72aa81351317c7f677df3abcb52078744d72b649","rpc":"127.0.0.1:80","pubtype":0,"p2shtype":85,"wiftype":188,"txfee":1000}]
[{"coin":"HYD","installed":false,"height":-1,"balance":17.69837806,"status":"active","smartaddress":"0x72aa81351317c7f677df3abcb52078744d72b649","rpc":"127.0.0.1:80","pubtype":0,"p2shtype":85,"wiftype":188,"txfee":1000}]
{"error":"couldnt find coin locally installed","coin":"IOP"}

Note, we don't use IOP in this test.

mm_console.txt coins.json.txt

artemii235 commented 6 years ago

@brrrrrr Hi, thanks for your report. Please perform following steps:

  1. Run Alice side in console mode and try to buy from Bob node.
  2. Provide full log of Bob's and Alice's sides: from marketmaker startup to SWAP never started error.
  3. Provide all Alice curl scripts with responses.
artemii235 commented 5 years ago

@brrrrrr Hi, the issue is not actual anymore in MM2. Please try to trade ETH/ERC20 again and open new issue if you need any help.

brrrrrr commented 5 years ago

thanks.

On Thu, Jun 20, 2019 at 12:42 PM Artem Pikulin notifications@github.com wrote:

Closed #90 https://github.com/artemii235/SuperNET/issues/90.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/artemii235/SuperNET/issues/90?email_source=notifications&email_token=AHCZY6WYMEQWMHXE72HWWODP3NNIJA5CNFSM4FH3RE3KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSCUP42I#event-2426994281, or mute the thread https://github.com/notifications/unsubscribe-auth/AHCZY6SC4LZP7ITPRYRSXJ3P3NNIJANCNFSM4FH3RE3A .