KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
102 stars 92 forks source link

[BUG] Incorrect behaviour of coins with mm2:0 parameter #919

Open SirSevenG opened 3 years ago

SirSevenG commented 3 years ago

Describe the bug It is possible to enable coins with "mm2":0 parameter in coins file.

Please answer following questions and attach requested info - it'll help to solve issue faster

(Pretty much any coin with "mm2":0)

{
                "coin": "RICK",
                "asset": "RICK",
                "fname": "RICK (TESTCOIN)",
                "rpcport": 25435,
                "txversion": 4,
                "overwintered": 1,
                "mm2": 0,
                "required_confirmations": 1,
                "requires_notarization": false,
                "avg_blocktime": 1,
                "protocol": {
                        "type": "UTXO"
                }
        },
curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"test\",\"method\":\"electrum\",\"coin\":\"RICK\",\"servers\":[{\"url\":\"electrum1.cipig.net:10017\",\"protocol\":\"TCP\",\"disable_cert_verification\":true},{\"url\":\"electrum2.cipig.net:10017\"}]}"

response:

{
  "result": "success",
  "address": "RADDRESS",
  "balance": "7.777",
  "unspendable_balance": "0",
  "coin": "RICK",
  "required_confirmations": 1,
  "requires_notarization": false,
  "mature_confirmations": 100
}
...
23 08:17:14, rpc:361] INFO >>>>>>>>>> DEX stats 127.0.0.1:7783 DEX stats API enabled at unixtime.1619165834  <<<<<<<<<
23 08:17:18, rpc_clients:1883] Electrum client connected to electrum1.cipig.net:10017
23 08:17:18, rpc_clients:1883] Electrum client connected to electrum2.cipig.net:10017
23 08:17:19, utxo:1287] Use protocol version 1.4 for Electrum "electrum1.cipig.net:10017"
23 08:17:19, utxo:1287] Use protocol version 1.4 for Electrum "electrum2.cipig.net:10017"
23 08:17:19, lp_coins:908] ticker = "RICK", block_count = 899636
23 08:17:24, atomicdex_gossipsub:behaviour:1200] INFO HEARTBEAT: relays low. Contains: 0 needs: 2
artemii235 commented 3 years ago

I've checked the code - it just checks that mm2 is not null, no matter what value does it have. I will fix it along with my ongoing SLP integration work.