KomodoPlatform / komodo-defi-framework

This is the official Komodo DeFi Framework repository
https://komodoplatform.com/en/docs/komodo-defi-framework/
103 stars 94 forks source link

Web browser support (WASM). #928

Closed artemii235 closed 2 years ago

sergeyboyko0791 commented 3 years ago
sergeyboyko0791 commented 3 years ago

RPC calls integration process

The list of RPC calls that are not planned to be integrated shortly:

artemii235 commented 3 years ago

@tonymorony I've recently merged the huge WASM integration PR to the dev branch. Could you please arrange testing according to this list https://github.com/KomodoPlatform/atomicDEX-API/pull/1007#issuecomment-908784815?

smk762 commented 2 years ago

Still a few tests do run, will report once complete this evening

smk762 commented 2 years ago

Orders testing in CLI completed without problem


update_maker_order RPC call works correctly;
my_orders RPC call work correctly for Maker and Taker orders;
orders_history_by_filter RPC call work correctly with many different parameter combinations. Especially for Maker and Taker orders;
order_status returns correct info of already matched/canceled Maker and Taker orders.
sergeyboyko0791 commented 2 years ago

@smk762 thanks for the testing! I have one question regarding

Maker orders created on app show up in orders list. Orders created in CLI are returned with myorders. Both are saved as json in DB//ORDERS/MY/MAKER. Orders created in app do not show up in myorders. Orders created in CLI do not show up in GUI orders list, but do show up in orderbook tagged as mine.

Is it expected behavior? I didn't quite understand what this test was :sweat_smile:

smk762 commented 2 years ago

Just a comment, seen while testing. I think it is just GUI processing differently, so no problem.

artemii235 commented 2 years ago

Just an idea for the future: implement a "WalletConnect" like protocol to connect the web instances running without hardware wallets and/or extension support to instances that have such support.

artemii235 commented 2 years ago

@sergeyboyko0791 Can we close this one? :slightly_smiling_face:

sergeyboyko0791 commented 2 years ago

I hope we can!