KomodoPlatform / komodo-docs-mdx

Komodo Platform Docs
https://komodoplatform.com/en/docs/
2 stars 7 forks source link

verify the multi language atomicdex code block's syntax is correct in all the supported languages #21

Open gcharang opened 1 year ago

gcharang commented 1 year ago

Add windows terminal support

smk762 commented 1 year ago

Tested bash on linux, and got a userpass error.

This is because "userpass": "$userpass" should actually be "userpass": "'$userpass'"

Looking at the other examples, the userpass variable does not change as required for other languages. E.g. in python, "${userpass}" would not return a variable value, it would return the same text.

So for python and likely most other langs we'll need to:

smk762 commented 1 year ago

Ideally, this can be one via CI/CD. We just need to test the output for each lang variation in codeblocks using one of the playground nodes for some simple methods not using auth, but if using an mm2 image on the runner instead would allow for greater coverage.

smk762 commented 2 days ago

@gcharang is this still required or can we close it?