search

KomodoPlatform / komodo-wallet-desktop

Komodo Wallet Desktop GUI
https://atomicdex.io
GNU General Public License v2.0
236 stars 206 forks source link

Inconsistent testcoin tagging #1194

Open smk762 opened 3 years ago

smk762 commented 3 years ago

testcoin tagging inconsistent :octopus: image image

Originally posted by @smk762 in https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/1193#issuecomment-899396957

Milerius commented 3 years ago

We could remove all the (testnet) stuff and add a test tag, i also suggest to turn back those tag type in the dashboard the same way as the first image (rounded tag) what do you think @tonymorony ?

smk762 commented 2 years ago

This will need updates to coins.json file in this repo (https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/assets/config/0.5.4-coins.json) and also coins repo (https://github.com/KomodoPlatform/coins/blob/master/coins#L7003)

There are a few variations in fname: Bitcoin Cash Testnet adex_bsc_testnet Blackcoin testnet binancesmartchaintest MORTY (TESTCOIN)

Some coins also have TEST in name, like: tBTC-TEST vs tQTUM

I propose removing TEST from coin field, and for fname to add a simple (test coin) consistently instead of the variations currently used.

Not sure if these changes to coins repo would maybe cause problems in mobile repo? @MateusRodCosta @yurii-khi

yurii-khi commented 2 years ago

On mobile we have "testCoin": true parameter in our local config file (which is quite different from the desktop config file). And on the air_dex we're using is_testnet field from 0.5.4-coins.json to identify test coins, and as a result missing coins like RICK or MORTY. So, yeah, it would be cool to have some consistent parameter similar to what we have for mobile.