KomodoPlatform / komodo-wallet-desktop

Komodo Wallet Desktop GUI
https://atomicdex.io
GNU General Public License v2.0
235 stars 207 forks source link

[FEATURE REQUEST]: Make volume filter for CEX price ratio configurable #1317

Open tonymorony opened 2 years ago

tonymorony commented 2 years ago

Right now it's 10k$ to protect users from fully non-liquid assets purchasing, we might set it much higher (e.g. 100k$/24h) and make this filter amount configurable in GUI with possibility to on/off so user will able to see low liquidity markets CEX ratio if they wish

smk762 commented 1 year ago

This should be taken into consideration wrt recent meeting discussing better price API

cipig commented 1 year ago

also keep in mind that some CEXs fake the volume massively, eg Finexbox, dex-trade (for some coins), Probit the method is well known and described here: https://www.sec.gov/comments/sr-nysearca-2019-01/srnysearca201901-5164833-183434.pdf (page 29ff, "TRADE PRINTING BETWEEN BID AND ASK") so i think it's problematic to base decisions on potentially fake data the effects can be seen here: https://www.coingecko.com/en/coins/feathercoin#markets image the volume of 20k from Finexbox is complete fake, the real volume is $320 (from Bittrex)

smk762 commented 1 year ago

I'm not sure this limit is defined with the source code of this repo? Will leave issue open for now, but might be better to migrate it to the repo which serves the price API.

cipig commented 1 year ago

I'm not sure this limit is defined with the source code of this repo? Will leave issue open for now, but might be better to migrate it to the repo which serves the price API.

It's defined here https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/src/core/atomicdex/models/qt.orderbook.proxy.model.cpp#L163 and used here https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/src/core/atomicdex/models/qt.orderbook.proxy.model.cpp#L170