tonymorony
commented
2 years ago Thank you for the issue opening!
The clue is that fiat prices at the moment of trade not recording now: price values in the orders history are based on the most recent (current) price information. So to have really useful information for export, at first we should make a DB with prices at the moment of trade for every trade
Is your feature request related to a problem? Please describe. This feature request is to expand on the trade history information that is exported as CSV. Currently the values exported are:
'Date', ' BaseCoin', ' BaseAmount', ' Status', ' RelCoin', ' RelAmount',' UUID', ' ErrorState'Describe the solution you'd like This feature request is to specifically add the values
BaseCoinAmountCurrentCurrencyRole,RelCoinAmountCurrentCurrencyRolewhich would help users calculate relevant capital gains/losses in their default fiat at the time of trade.Describe alternatives you've considered Alternatively, attempting to calculate gains or losses in fiat would involve manually looking up each coins price at that specific time for each trade, which relies on a 3rd party price source that may have been different from the prices within the DEX.
Additional context I believe CSV export values are selected here: https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/ebdb7042d6d97a7bf298363d43ab64741e68b5e6/src/core/atomicdex/models/qt.orders.proxy.model.cpp#L277
and the options to choose from are here: https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/4c023b1780a501a3f13ff285018904289b53a494/src/core/atomicdex/models/qt.orders.model.cpp#L45