KomodoPlatform / komodo-wallet-desktop

Komodo Wallet Desktop GUI
https://atomicdex.io
GNU General Public License v2.0
237 stars 201 forks source link

Addressbook restyle tweaks 🎉 #1770

Closed smk762 closed 2 years ago

smk762 commented 2 years ago

Crashing:

https://user-images.githubusercontent.com/35845239/168439634-e48e4d3c-6301-4e84-91f5-7e51462f786c.mp4

https://user-images.githubusercontent.com/35845239/168439631-58889c80-0f57-4774-97a9-088731b25ef4.mp4

[22:16:06] [error] [mm2.service.cpp:501] [35910]: error answer for tx or my_balance: {
    "error": "rpc:211] dispatcher_legacy:160] lp_coins:1419] No such coin: Smart Chain"
}
[22:16:06] [error] [main.prerequisites.hpp:112] [35899]: stacktrace:  0# signal_handler(int) at main.cpp:?
 1# 0x00007F30EB7D50C0 in /lib/x86_64-linux-gnu/libc.so.6
 2# atomic_dex::wallet_page::get_ticker_infos() const in ./atomicdex-desktop
 3# atomic_dex::wallet_page::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) in ./atomicdex-desktop
 4# 0x00007F30EE2719CE in /home/smk762/Downloads/atomicdex-desktop-ubuntu-qt-5-15-2-abook.zip/atomicdex-desktop-linux-0603cb0/AntaraAtomicDexAppDir/usr/bin/../lib/libQt5Qml.so.5
 5# 0x00007F307022DFBF
smk762 commented 2 years ago

Bugs

https://user-images.githubusercontent.com/35845239/168439740-0be7e672-2eff-4b1e-b65f-31e220493500.mp4

https://user-images.githubusercontent.com/35845239/168439752-bfea66d5-64a6-4fdb-b1c7-0cdf7fb60f3e.mp4

image

https://user-images.githubusercontent.com/35845239/168439786-441385d2-ba26-4dde-aa5c-07cbfc72df3f.mp4

https://user-images.githubusercontent.com/35845239/168439806-bac486d3-e42f-4d65-a0cd-ed98138f3ab5.mp4

smk762 commented 2 years ago

Layout / Components

https://user-images.githubusercontent.com/35845239/168439838-e7d4e04b-cf0b-4c3b-afb5-690c3ff2f4d0.mp4

smk762 commented 2 years ago

UX

It's really annoying to do so many steps. So, is it possible to show the "edit contact" window after pressing the "+new contact" button to avoid unnecessary actions?



- [x] The `Label: Address` format used on main age could also be used on the edit contact page. This would allow for more addresses visible in the scrolling area. A space should be added after the `:` to allow for wordwrap if long label/address needing extra line.
![image](https://user-images.githubusercontent.com/35845239/168432216-279191c5-ec5e-4952-8be1-e7e16515a8a3.png)
![image](https://user-images.githubusercontent.com/35845239/168432254-ff98aacd-f2f9-4363-91fc-034c7606ede5.png)

- [x] Tags background is difficult to see (make tags colorful)
![image](https://user-images.githubusercontent.com/35845239/168429434-25bb79a6-08c8-44ba-9015-e93146ef8858.png)
![image](https://user-images.githubusercontent.com/77272165/168334937-b688fce9-f08b-4432-a807-f26241e75f0d.png)

- [x] If no tags for entry, leave area blank (on main page). 

- [ ]  A slight change to background color of address list area like below might be a good idea, along with a "There are no saved addresses for this contact" message if no addresses in list. Same for tags area, along with a `no tags for this contact` message if no tags are set. Similar to below:
![image](https://user-images.githubusercontent.com/35845239/168430372-485fc62f-631b-4143-9496-32b1a7407b59.png)
smk762 commented 2 years ago

Enhancements ~It would be cool to be able to add addresses to the addressbook via a button next to addresses on transaction details modal.~ Moved to https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/1781 image

ghost commented 2 years ago
  • Coin selection dropdown might benefit from slightly different background and adding a search field.

We should not use different colors when component has already one defined in themes, it will make the application harder to maintain accross other themes

In that case reducing dropdown height should be sufficient

+1 for the searchbar

ghost commented 2 years ago
  • It would be cool to be able to add addresses to the addressbook via a button next to addresses on transaction details modal. image

Not directly related to addressbook, should be put in another issue