Closed smk762 closed 2 years ago
Bugs
[ ] There is a bug with the name. After some actions, the name of another contact is entered in the "name" field for other contacts. Perhaps the cause of crash
Item 1. (@Canialon) exploring it.
[x] Unexpected behaviour when using send button on coins which are not enabled. In this case, I would expect a pop up to enable the coin, and if cancelling the enable, it should not appear as the selected coin in wallet screen afterwards.
Layout / Components
[x] There is too much empty space, under the contacts with addresses
[x] Error message would be good to be centered between buttons and inputs, and perhaps center aligned.
[x] Add horizontal center alignment to elements
[x] Reduce spacing between address entries
[x] "Contact name" field. I can't start typing immediately after pressing the "+new contact" button. Input gives no indicator when focused (i.e. blinking cursor or slight background / border change)
[ ] Contact name edit input would be nice to use similar to the notes input on sent transactions:
[x] Address input fields should be renamed to Label
and Address
. Using "field" and "key" might confuse grandma.
[x] Buttonize the edit / delete buttons on main page
UX
[x] Add a "do you confirm?" pop up when clicking delete
for a contact.
[x] Streamline new contact creation
And I am a little bit unsure about this way to create a new contact. I mean when I press
the "+new contact" button, I expect to see a big window where I can add the name of the
contact, and add some address and tags. But now to do that I must:
create a contact name
find this contact among other contacts
press the "edit" button
only then I can add some addresses.
It's really annoying to do so many steps. So, is it possible to show the "edit contact" window after pressing the "+new contact" button to avoid unnecessary actions?
- [x] The `Label: Address` format used on main age could also be used on the edit contact page. This would allow for more addresses visible in the scrolling area. A space should be added after the `:` to allow for wordwrap if long label/address needing extra line.
![image](https://user-images.githubusercontent.com/35845239/168432216-279191c5-ec5e-4952-8be1-e7e16515a8a3.png)
![image](https://user-images.githubusercontent.com/35845239/168432254-ff98aacd-f2f9-4363-91fc-034c7606ede5.png)
- [x] Tags background is difficult to see (make tags colorful)
![image](https://user-images.githubusercontent.com/35845239/168429434-25bb79a6-08c8-44ba-9015-e93146ef8858.png)
![image](https://user-images.githubusercontent.com/77272165/168334937-b688fce9-f08b-4432-a807-f26241e75f0d.png)
- [x] If no tags for entry, leave area blank (on main page).
- [ ] A slight change to background color of address list area like below might be a good idea, along with a "There are no saved addresses for this contact" message if no addresses in list. Same for tags area, along with a `no tags for this contact` message if no tags are set. Similar to below:
![image](https://user-images.githubusercontent.com/35845239/168430372-485fc62f-631b-4143-9496-32b1a7407b59.png)
Enhancements
~It would be cool to be able to add addresses to the addressbook via a button next to addresses on transaction details modal.~
Moved to https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/1781
[x] Coin selection dropdown might benefit from slightly different background and adding a search field.
[ ] Rather than an "+ Add" button below the scrollable, address list, we could make a small +
button to the right of the Address list
title. Same applies for the Tags
title. These changes would almost double the available space for the scrollable address list area. e.g.
- Coin selection dropdown might benefit from slightly different background and adding a search field.
We should not use different colors when component has already one defined in themes, it will make the application harder to maintain accross other themes
In that case reducing dropdown height should be sufficient
+1 for the searchbar
- It would be cool to be able to add addresses to the addressbook via a button next to addresses on transaction details modal.
Not directly related to addressbook, should be put in another issue
Crashing:
[x] Found on Windows 10:
[x] When clicking "send" button for smartchain, app crashes. In this case, user should be given a pop-up list of smartchains to complete the selection.
https://user-images.githubusercontent.com/35845239/168439634-e48e4d3c-6301-4e84-91f5-7e51462f786c.mp4
https://user-images.githubusercontent.com/35845239/168439631-58889c80-0f57-4774-97a9-088731b25ef4.mp4