KomodoPlatform / komodo-wallet-desktop

Komodo Wallet Desktop GUI
https://atomicdex.io
GNU General Public License v2.0
236 stars 206 forks source link

[FEATURE REQUEST]: Address book #312

Closed Milerius closed 4 years ago

Milerius commented 4 years ago

Is your feature request related to a problem? Please describe.

The feature is not linked to a problem but to a lack. We have no way of registering a public address for a name.

Describe the solution you'd like

I would like to be able to associate a public address with a name, this name could be associated with all a group like "ERC-20" or "SmartChains".

Later we could add categories: Friends, Professional, Contractual

Describe alternatives you've considered

Currently I use an external tool to which I associate an address to a name, but I therefore need to copy my public address from the application and then perform the search in my tool. It is laborious.

Additional context

A Json attempt of the addressbook format added to the wallet configuration:

{
    "wallet_name": "roman",
    "addressbook": {
        "ca333": {
            "ERC-20": "0xde0b295669a9fd93d5f28d9ec85e40f4cb697bae",
            "SmartChains": "RB49Rm4jBe5mN9anErvkzf3kcQCzHqyz3e",
            "BTC": "3FZbgi29cpjq2GjdwV8eyHuJJnkLtktZc5"
        },
        "alice": {
            "ERC-20": "0xde0b395669a9fd93d5f28d9ec85e40f4cb697bae",
            "SmartChains": "RB39Rm4jBe5mN9anErvkzf3kcQCzHqyz3e",
            "BTC": "3FZbgi30cpjq2GjdwV8eyHuJJnkLtktZc5"
        },
        "bob": {
            "ERC-20": "0xde0b393669a9fd93d5f28d9ec85e40f4cb697bae",
            "SmartChains": "RB39Rm6jBe5mN9anErvkzf3kcQCzHqyz3e",
            "BTC": "3FZbgi30cpjq3GjdwV8eyHuJJnkLtktZc5"
        }
    },
    "categories": {
        "friends": [
            "ca333"
        ],
        "pro": [
            "alice"
        ],
        "black_list": [
            "bob"
        ]
    }
}
tonymorony commented 4 years ago

Address Book Desktop Concept

I think there might be dropdown scrollable list linked with addressbook when you input recepient (probably Audo can make it beautiful):

cf: https://github.com/KomodoPlatform/atomicDEX-Pro/issues/128

image

Also I've noticed that there is a lot of free space at the moment. I think it's fine to put addressbook button here for now (between receive and swap):

image

tonymorony commented 4 years ago

impleneted in https://github.com/KomodoPlatform/atomicDEX-Pro/pull/357