KomodoPlatform / komodo-wallet-mobile

KomodoWallet Mobile codebase
https://komodoplatform.com
MIT License
21 stars 31 forks source link

[RC] `0.9.1`: Chart & Order Book Fixes + Sync assets #123

Closed CharlVS closed 1 month ago

CharlVS commented 2 months ago

0.9.1 Release Candidate PR

Various bug fixes and minor improvements relating to advanced view order book and candlestick chart.

Outstanding TODO:

Project changelog:

Dependency changelog & review:

Not applicable (no changes)

smk762 commented 2 months ago

It all looks good, except for a couple of screens which I end up with an endless spinner.

Simple dex orderbook is fine, so it doesnt seem to be a connectivity issue. Logs only have one error including the string "orderbook" - {"mmrpc":"2.0","error":"BaseRelSameOrderbookTickersAndProtocols","error_path":"orderbook_rpc","error_trace":"orderbook_rpc:250]","error_type":"BaseRelSameOrderbookTickersAndProtocols","id":null}.

By disabling any coins with a legacy/segwit variant (or only having one of the variants active), these pages load ok.

CharlVS commented 2 months ago

@smk762 I've merged the fix for the bug you mentioned. I would appreciate it if you or one of your team members could still create an issue with steps/conditions to reproduce the long loading times you reported.

AndrewDelaney commented 1 month ago

@CharlVS @smk762 I have created the associated issue regarding the orderbook spinner here