Closed CharlVS closed 1 year ago
@CharlVS what API library version needs to be used for testing?
@tonymorony
@CharlVS, what API library version needs to be used for testing?
Flutter 2.8.1
with the latest stable release of Komodo API.
Will add @ca333 as a reviewer after QA approval.
@yurii-khi Could you please review this?
Branding (logos and wording) looks good. I was unable to see DOC / MARTY in the activation list tho (I did run ./fetch_coins.sh).
@CharlVS I Tested on iOS 16.4.1. In common branding changes looks correct. I saw only one issue. On Starting (loading) screen AtomicDex icon displayed first for a moment and after that it changed for new logo. Some times it looks like gray square picture displayed first after that Komodo wallet icon appears. Cant attach video because screen capture is forbidden
@kivqa Did you try completely removing app data and uninstalling it before installing this new version?
@kivqa Did you try completely removing app data and uninstalling it before installing this new version?
@naezith I did two tests for iOS device:
Build dev branch on iPhone and after that update build using new brand branch. Result: Observing issue with AtomicDex logo
Uninstall atomicdex app from iOS app, reboot device, and install build with new brand branch Result: komodo-wallet logo displayed inside gray square
Thanks @kivqa for reporting the issues. I will get the assets for iOS from the design team.
@kivqa Can you please take another look at iOS?
In my Android 12 (Go Edition) overall looks good. No issue with icon when app opens firstly, rebranded icon was okay.
Some new issues:
@CharlVS on iOS app I observe
that komodo logo change size on loading without any animation. I cant capture this behavior due screen recording is prohibited in the appm but its easy to reproduce.
after app upgrade atomicdex icon app still displayed on until device reboot or may be some long time waiting. Can we force icon app update?
how many times should we display 'Official press release' banner on app start?
I observed it few times. Should we display it until user taped on the press release link in the banner?
I observe 'Official press release' banner over Passcode screen, its really does not look good.
@endrilickollari @kivqa Please check the app icons and launch screen for iOS and Android.
@kivqa The notice is shown when the user opens the app. The notice is never shown again if the user presses the close icon or opens the press release.
@endrilickollari @kivqa Please check the app icons and launch screen for iOS and Android.
@kivqa The notice is shown when the user opens the app. The notice is never shown again if the user presses the close icon or opens the press release.
The icons look good now.
@CharlVS
1. logo size still jumping on Loading screen for iOS app
@kivqa thanks for that. I'll create a separate task for these polishes in the next release. It is a bit of a challenge to get the native Android/iOS code splash screens (the first one shown) to transition seamlessly to our universal Flutter code loading screen for all screen sizes of all platforms.
2. on iOS app Official release banner appears after Confirm passcode screen for few seconds. After that Confirm passcode screen displays again. Looks strange
@naezith can you please look at this? In the attached video, the rebranding notice should not be shown until the user has completed the sign-up process.
3. on iOS app some times after user click official release and come back to app. Banner displays over passcode screen
@kivqa this is working as expected.
- on iOS app Official release banner appears after Confirm passcode screen for few seconds. After that Confirm passcode screen displays again. Looks strange
@naezith can you please look at this? In the attached video, the rebranding notice should not be shown until the user has completed the sign-up process.
CoinsPage
's initState()
opens the dialog at the moment. @CharlVS
void initState() {
_scrollController = ScrollController();
_scrollController.addListener(_scrollListener);
if (mmSe.running) coinsBloc.updateCoinBalances();
// Schedule the dialog to show after the current frame
SchedulerBinding.instance.addPostFrameCallback((_) async {
final rebrandingNotifier =
Provider.of<RebrandingProvider>(context, listen: false);
// Wait for the prefs to load
await rebrandingNotifier.prefsLoaded;
if (!rebrandingNotifier.closedPermanently &&
!rebrandingNotifier.closedThisSession) {
showRebrandingDialog(context);
}
});
super.initState();
}
I'll check how else we can do it.
These changes should solve it: https://github.com/KomodoPlatform/komodo-wallet-mobile/compare/release/rc_v0.6.6_rebranding...naezith:komodo-wallet-mobile:fix-branding-popup
Now we are listening to authBloc
's isLogin
to turn true
. @CharlVS
Looks good in Android 12 also 👍🏻
@CharlVS
Issue 2 is still reproducible: on iOS app Official release banner appears after Confirm passcode screen for few seconds. After that Confirm passcode screen displays again. Can you check on your devices?
Screen became in white when I tap faucet button for Rick
@CharlVS same behavior for faucet on Android Pixel 5 Android 13. No new branding issues on Android were observed
@kivqa Please create a new issue with the problems you've described, including steps to reproduce. Please approve this PR if there are no significant issues and it meets the standard for public release.
@ca333 after merging in, please rebase/merge with dev
. Note that the way I've done isn't in line with the org's prescribed org's PR protocols where individual features should be merged into dev
and then RC PRs into main
.
This PR brings the project in line with Komodo's rebranding strategy. https://komodoplatform.com/en/blog/brand-unification/
Changelog:
KomodoPlatform/coins
. New coins were added, and existing coins were updated.KomodoPlatform/coins
.