KomodoPlatform / komodo-wallet

Komodo Wallet
https://app.komodoplatform.com
GNU General Public License v3.0
242 stars 211 forks source link

[BUG]: Show low volume coins price as N/A in simple trading view #1316

Closed cipig closed 2 years ago

cipig commented 3 years ago

Steps to reproduce:

The result is empty: image

but AUR/KMD orderbook contains enough entries, the cheapest one is this, which should be part of the answer:

      "coin": "AUR",
      "price": "0.165",
      "maxvolume": "996",
      "min_volume": "0.00105",

unfortunately there are also orders like this in the orderbook:

      "coin": "AUR",
      "price": "0.17131904",
      "maxvolume": "19.6403061",
      "min_volume": "19.6403061",

those are not usable for simple swap, since you would need to match the amount exactly could they be part of the problem?

cipig commented 3 years ago

buying from the cheapest ask in pro view works fine, ~ same amount as above, order matches image so this ask

      "coin": "AUR",
      "price": "0.165",
      "maxvolume": "996",
      "min_volume": "0.00105",

should definitely be part of the answer in simple view

tonymorony commented 3 years ago

we did exclude completely coins with <10k$ daily volume from the simple trading view to protect the users, probably it's still excluded because of that. we should display such coins with CEX rate as N/A if it's the case @Milerius

cipig commented 3 years ago

the coin has a CEX rate, this one is from the above ask: image

tonymorony commented 3 years ago

the coin has a CEX rate, this one is from the above ask: image

it's in a Pro view

cipig commented 3 years ago

it works the other way around, selling AUR: image

what about this? image

honestly, i would remove the volume limit, list contains anyways coins like AXE, with a fake volume on Hotbit: image orderbook is empty, but trade history contains trades 100x higher than orderbook, all priced between best ask and best bid: image

tonymorony commented 3 years ago

honestly, i would remove the volume limit, list contains anyways coins like AXE, with a fake volume on Hotbit: it's quite hard to moderate everything, we just excluded totally dead coins for now from cex price calculator, probably volume limit should be much higher with an option to configure/disable it by the user - will open an issue for that now

auroracoin101 commented 3 years ago

Just as another thought.... Komodo platform is promoting decentralized trades, yet coins like Auroracoin are filtered out because of centralized exchange volume, despite having more volume on AtomicDEX than many higher volume coins.

Perhaps we are in a unique position as we are having to re-establish ourselves from the previous team members being less active.

Thanks for all the consideration. mikael hannes